From: Mark McLoughlin <markmc@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: avi@redhat.com, kvm@vger.kernel.org
Subject: Re: Add qemu_send_raw() to vlan.
Date: Tue, 26 May 2009 11:34:40 +0100 [thread overview]
Message-ID: <1243334080.19124.16.camel@blaa> (raw)
In-Reply-To: <20090526100302.GS3948@redhat.com>
On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote:
> It gets packet without virtio header and adds it if needed. Allows to
> inject packets to vlan from outside. To send gracious arp for instance.
Acked-by: Mark McLoughlin <markmc@redhat.com>
This isn't ideal, but neither is the current VNET_HDR stuff and it does
fix a genuine bug. At least it's not changing existing APIs and makes it
clear this is a problem we also need to solve when merging VNET_HDR
support upstream.
(Gleb - it might be worth patching qemu.git to use qemu_send_packet() in
announce_self(), that will reduce the delta between the trees)
Cheers,
Mark.
next prev parent reply other threads:[~2009-05-26 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 10:03 Add qemu_send_raw() to vlan Gleb Natapov
2009-05-26 10:05 ` Avi Kivity
2009-05-26 10:08 ` Gleb Natapov
2009-05-26 10:11 ` Avi Kivity
2009-05-26 10:28 ` Mark McLoughlin
2009-05-26 10:34 ` Mark McLoughlin [this message]
2009-05-26 11:15 ` Avi Kivity
2009-05-26 12:05 ` Gleb Natapov
2009-05-26 12:20 ` Avi Kivity
2009-10-15 7:04 ` Mark McLoughlin
2009-10-15 7:33 ` Gleb Natapov
2009-10-15 7:36 ` Mark McLoughlin
2009-10-15 22:46 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243334080.19124.16.camel@blaa \
--to=markmc@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).