From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: Add qemu_send_raw() to vlan.
Date: Tue, 26 May 2009 11:34:40 +0100
Message-ID: <1243334080.19124.16.camel@blaa>
References: <20090526100302.GS3948@redhat.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: avi@redhat.com, kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:41341 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751527AbZEZKel (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 26 May 2009 06:34:41 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4QAYh6Q030266
	for <kvm@vger.kernel.org>; Tue, 26 May 2009 06:34:43 -0400
In-Reply-To: <20090526100302.GS3948@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote:
> It gets packet without virtio header and adds it if needed.  Allows to
> inject packets to vlan from outside. To send gracious arp for instance.

Acked-by: Mark McLoughlin <markmc@redhat.com>

This isn't ideal, but neither is the current VNET_HDR stuff and it does
fix a genuine bug. At least it's not changing existing APIs and makes it
clear this is a problem we also need to solve when merging VNET_HDR
support upstream.

(Gleb - it might be worth patching qemu.git to use qemu_send_packet() in
announce_self(), that will reduce the delta between the trees)

Cheers,
Mark.