From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
Subject: Re: [PATCH] kvm-kmod: Add MSR_K7_HWCR and MSR_K8_SYSCFG compat
 definition
Date: Wed, 27 May 2009 15:25:26 +0530
Message-ID: <1243418126.3109.18.camel@localhost.localdomain>
References: <20090526115251.3362.54734.stgit@mchn012c.ww002.siemens.net>
	 <4A1BE668.7090106@siemens.com>  <4A1C58A5.1030700@web.de>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from hera.kernel.org ([140.211.167.34]:49549 "EHLO hera.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1760931AbZE0J4f (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 27 May 2009 05:56:35 -0400
In-Reply-To: <4A1C58A5.1030700@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hello Jan,

On Tue, 2009-05-26 at 23:01 +0200, Jan Kiszka wrote:
> Reposted as joint patch as there is no MSR_K7 in your next queue.
> 
> -------->
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
>  x86/external-module-compat.h |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h
> index 445c7a1..0e26743 100644
> --- a/x86/external-module-compat.h
> +++ b/x86/external-module-compat.h
> @@ -496,6 +496,14 @@ struct kvm_desc_ptr {
>  #define MSR_IA32_TSC                    0x00000010
>  #endif
>  
> +#ifndef MSR_K7_HWCR
> +#define MSR_K7_HWCR                     0xc0010015
> +#endif
> +
> +#ifndef MSR_K8_SYSCFG
> +#define MSR_K8_SYSCFG                   0xc0010010
> +#endif
> +

It will look more beautiful if we arrange MSR addresses in some order
(say increasing order) :

+#ifndef MSR_K8_SYSCFG
+#define MSR_K8_SYSCFG                   0xc0010010
+#endif
+
+#ifndef MSR_K7_HWCR
+#define MSR_K7_HWCR                     0xc0010015
+#endif
+

Thanks,
--
JSR