From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [KVM-AUTOTEST PATCH] Use new function VM.get_name() to get the VM's name, instead of VM.name Date: Thu, 28 May 2009 10:06:57 -0300 Message-ID: <1243516017.2976.1011.camel@localhost.localdomain> References: <8e37a36c044c20259dcd8a34d72a651e85b37d5f.1243179847.git.mgoldish@redhat.com> <838bcae1b49be011e2cde1294a391a296059464a.1243179847.git.mgoldish@redhat.com> <6a70cb56a775fdb688da0231073abb0ce4baa7b1.1243179847.git.mgoldish@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54901 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755976AbZE1NG6 (ORCPT ); Thu, 28 May 2009 09:06:58 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4SD70qr018894 for ; Thu, 28 May 2009 09:07:00 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Sun, 2009-05-24 at 18:46 +0300, Michael Goldish wrote: > kvm_vm.py: add function VM.get_name(). > kvm_preprocessing.py: use VM.get_name() instead of directly accessing the .name > attribute. Are there any advantages of creating this method over directly accessing the attribute? > Signed-off-by: Michael Goldish > --- > client/tests/kvm_runtest_2/kvm_preprocessing.py | 6 +++--- > client/tests/kvm_runtest_2/kvm_vm.py | 4 ++++ > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/client/tests/kvm_runtest_2/kvm_preprocessing.py b/client/tests/kvm_runtest_2/kvm_preprocessing.py > index c9eb35d..bcabf5a 100644 > --- a/client/tests/kvm_runtest_2/kvm_preprocessing.py > +++ b/client/tests/kvm_runtest_2/kvm_preprocessing.py > @@ -178,7 +178,7 @@ def preprocess(test, params, env): > if vm.is_dead(): > continue > if not vm.verify_process_identity(): > - kvm_log.debug("VM '%s' seems to have been replaced by another process" % vm.name) > + kvm_log.debug("VM '%s' seems to have been replaced by another process" % vm.get_name()) > vm.pid = None > > # Destroy and remove VMs that are no longer needed in the environment > @@ -187,8 +187,8 @@ def preprocess(test, params, env): > vm = env[key] > if not kvm_utils.is_vm(vm): > continue > - if not vm.name in requested_vms: > - kvm_log.debug("VM '%s' found in environment but not required for test; removing it..." % vm.name) > + if not vm.get_name() in requested_vms: > + kvm_log.debug("VM '%s' found in environment but not required for test; removing it..." % vm.get_name()) > vm.destroy() > del env[key] > > diff --git a/client/tests/kvm_runtest_2/kvm_vm.py b/client/tests/kvm_runtest_2/kvm_vm.py > index fab839f..df99859 100644 > --- a/client/tests/kvm_runtest_2/kvm_vm.py > +++ b/client/tests/kvm_runtest_2/kvm_vm.py > @@ -454,6 +454,10 @@ class VM: > """Return True iff the VM's PID does not exist.""" > return not kvm_utils.pid_exists(self.pid) > > + def get_name(self): > + """Return the VM's name.""" > + return self.name > + > def get_params(self): > """Return the VM's params dict. > -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies