From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [KVM-AUTOTEST PATCH] kvm_runtest_2.py: use environment filename specified by the 'env' parameter Date: Thu, 28 May 2009 10:26:29 -0300 Message-ID: <1243517189.2976.1051.camel@localhost.localdomain> References: <8e37a36c044c20259dcd8a34d72a651e85b37d5f.1243179847.git.mgoldish@redhat.com> <838bcae1b49be011e2cde1294a391a296059464a.1243179847.git.mgoldish@redhat.com> <6a70cb56a775fdb688da0231073abb0ce4baa7b1.1243179847.git.mgoldish@redhat.com> <63bacaa214ccd95c18fb644056855acd72757ac4.1243179847.git.mgoldish@redhat.com> <43f85767b32b927ca5e32abc5ded281915343656.1243179847.git.mgoldish@redhat.com> <626078156e56b4fd573de078b2f1424e47e8f637.1243179847.git.mgoldish@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37702 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755302AbZE1N0a (ORCPT ); Thu, 28 May 2009 09:26:30 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4SDQXM0024749 for ; Thu, 28 May 2009 09:26:33 -0400 In-Reply-To: <626078156e56b4fd573de078b2f1424e47e8f637.1243179847.git.mgoldish@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, 2009-05-24 at 18:46 +0300, Michael Goldish wrote: > Do not use hardcoded environment filename 'env'. Instead use the value > specified by the 'env' parameter. If unspecified, use 'env' as the filename. Looks good to me! > This is important for parallel execution; it may be necessary to use a separate > environment file for each process. > > Signed-off-by: Michael Goldish > --- > client/tests/kvm_runtest_2/kvm_runtest_2.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/client/tests/kvm_runtest_2/kvm_runtest_2.py b/client/tests/kvm_runtest_2/kvm_runtest_2.py > index fda7282..a69951b 100644 > --- a/client/tests/kvm_runtest_2/kvm_runtest_2.py > +++ b/client/tests/kvm_runtest_2/kvm_runtest_2.py > @@ -64,7 +64,7 @@ class kvm_runtest_2(test.test): > self.write_test_keyval({key: params[key]}) > > # Open the environment file > - env_filename = os.path.join(self.bindir, "env") > + env_filename = os.path.join(self.bindir, params.get("env", "env")) > env = shelve.open(env_filename, writeback=True) > kvm_log.debug("Contents of environment: %s" % str(env)) > -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies