From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [KVM-AUTOTEST PATCH] VM.create(): always destroy() the VM before attempting to start it Date: Thu, 28 May 2009 11:17:41 -0300 Message-ID: <1243520261.2976.1079.camel@localhost.localdomain> References: <8e37a36c044c20259dcd8a34d72a651e85b37d5f.1243179847.git.mgoldish@redhat.com> <838bcae1b49be011e2cde1294a391a296059464a.1243179847.git.mgoldish@redhat.com> <6a70cb56a775fdb688da0231073abb0ce4baa7b1.1243179847.git.mgoldish@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56330 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758907AbZE1ORn (ORCPT ); Thu, 28 May 2009 10:17:43 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4SEHjmn008598 for ; Thu, 28 May 2009 10:17:45 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Sun, 2009-05-24 at 18:46 +0300, Michael Goldish wrote: > Also, don't do it in kvm_preprocessing.py since it's now done in kvm_vm.py. Looks good to me! > Signed-off-by: Michael Goldish > --- > client/tests/kvm_runtest_2/kvm_preprocessing.py | 1 - > client/tests/kvm_runtest_2/kvm_vm.py | 2 ++ > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/client/tests/kvm_runtest_2/kvm_preprocessing.py b/client/tests/kvm_runtest_2/kvm_preprocessing.py > index bcabf5a..9ccaf78 100644 > --- a/client/tests/kvm_runtest_2/kvm_preprocessing.py > +++ b/client/tests/kvm_runtest_2/kvm_preprocessing.py > @@ -84,7 +84,6 @@ def preprocess_vm(test, params, env, name): > start_vm = True > > if start_vm: > - vm.destroy() > if not vm.create(name, params, qemu_path, image_dir, iso_dir, for_migration): > message = "Could not start VM" > kvm_log.error(message) > diff --git a/client/tests/kvm_runtest_2/kvm_vm.py b/client/tests/kvm_runtest_2/kvm_vm.py > index df99859..a1462c6 100644 > --- a/client/tests/kvm_runtest_2/kvm_vm.py > +++ b/client/tests/kvm_runtest_2/kvm_vm.py > @@ -238,6 +238,8 @@ class VM: > stored in the class attributes is used, and if it is supplied, it is stored > for later use. > """ > + self.destroy() > + > if name != None: > self.name = name > if params != None: -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies