public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: "Christian Bornträger" <borntraeger@de.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>,
	KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: add localversion to avoid confusion and conflicts
Date: Fri, 29 May 2009 14:13:46 +0530	[thread overview]
Message-ID: <1243586626.4379.15.camel@localhost.localdomain> (raw)
In-Reply-To: <200905290948.34482.borntraeger@de.ibm.com>

On Fri, 2009-05-29 at 09:48 +0200, Christian Bornträger wrote:
> Am Freitag 29 Mai 2009 09:18:14 schrieb Jaswinder Singh Rajput:
> > Adding localversion avoids confusion in kernel images :
> >
> > like Linux version 2.6.30-rc7 does not tell whether it is linus or kvm
> > kernel.
> >
> > By adding localversion it tells :
> >
> > Linux version 2.6.30-rc7-kvm , any doubt ;-)
> > I am inspired by Ingo's -tip, I am sure Ingo will tell more advantages,
> > if these are not enough :-)
> [...]
> > diff --git a/localversion-kvm b/localversion-kvm
> > new file mode 100644
> > index 0000000..d969ff0
> > --- /dev/null
> > +++ b/localversion-kvm
> > @@ -0,0 +1 @@
> > +-kvm
> 
> NAK from my side. If you need a distinction, there is always 
> CONFIG_LOCALVERSION_AUTO. If you need this kind of prefix, there is always  
> CONFIG_LOCALVERSION.
> 

Here is NAK for your NAK from my side.

This patch is only for KVM tree and not for linus tree.

Lets assume 100 developers are working on kvm tree and they use kvm tree
on 2 PCs. So count becomes 200.

Like in my case I have dozen of kernel trees so I keep on swapping
config between kernels. And I also need to test config from various
users. So this count is countless.
I think this is the biggest point for adding localversion in -tip.
It seems Ingo is busy in perfcounter stuff otherwise he will explain you
more advantages.

In the least case, Can you differentiate between 1 and 200 ?

So by adding this patch we can save lot of developer's time.

--
JSR


  reply	other threads:[~2009-05-29  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29  7:18 [PATCH] KVM: add localversion to avoid confusion and conflicts Jaswinder Singh Rajput
2009-05-29  7:48 ` Christian Bornträger
2009-05-29  8:43   ` Jaswinder Singh Rajput [this message]
2009-05-29  9:29     ` Christian Bornträger
2009-06-01 19:26     ` Steven Rostedt
2009-06-01 19:48       ` Avi Kivity
2009-06-01 19:53         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243586626.4379.15.camel@localhost.localdomain \
    --to=jaswinder@kernel.org \
    --cc=avi@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox