From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: [PATCH 1/3] KVM: VMX: Avoid duplicate ept tlb flush when setting cr3 Date: Mon, 1 Jun 2009 16:22:01 +0300 Message-ID: <1243862524-22120-2-git-send-email-avi@redhat.com> References: <1243862524-22120-1-git-send-email-avi@redhat.com> Cc: Marcelo Tosatti , Joerg Roedel , Sheng Yang To: kvm@vger.kernel.org Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58766 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757415AbZFANWG (ORCPT ); Mon, 1 Jun 2009 09:22:06 -0400 In-Reply-To: <1243862524-22120-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: vmx_set_cr3() will call vmx_tlb_flush(), which will flush the ept context. So there is no need to call ept_sync_context() explicitly. Signed-off-by: Avi Kivity --- arch/x86/kvm/vmx.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 25f1239..5607de8 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -1642,7 +1642,6 @@ static void vmx_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3) if (enable_ept) { eptp = construct_eptp(cr3); vmcs_write64(EPT_POINTER, eptp); - ept_sync_context(eptp); ept_load_pdptrs(vcpu); guest_cr3 = is_paging(vcpu) ? vcpu->arch.cr3 : VMX_EPT_IDENTITY_PAGETABLE_ADDR; -- 1.6.0.6