From: Nitin A Kamble <nitin.a.kamble@intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [patch] VMX Unrestricted mode support
Date: Mon, 01 Jun 2009 11:06:49 -0700 [thread overview]
Message-ID: <1243879609.30052.1.camel@mukti.sc.intel.com> (raw)
In-Reply-To: <4A224229.6090108@redhat.com>
On Sun, 2009-05-31 at 01:39 -0700, Avi Kivity wrote:
> Thanks, this is much needed. Review comments below.
>
> Please avoid hiding computations in macros. Just change the call sites.
> Instead of changing all the checks like this, you can make rmode.active
> be false when unrestricted guest is enabled. We can interpret
> rmode.active as "emulating real mode via vm86", not as "guest is in real
> mode".
>
> You can just have enter_rmode() exit immediately when called.
>
> I think this can go away if rmode.active == 0.
>
Avi,
Thanks for your comments. I will cook another patch for this feature
as per your comments.
Thanks & Regards,
Nitin
next prev parent reply other threads:[~2009-06-01 18:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 23:11 [patch] VMX Unrestricted mode support Nitin A Kamble
2009-05-28 23:39 ` Alexey Eremenko
2009-05-29 4:04 ` [patch] VMX Unrestricted guest " Nitin A Kamble
2009-05-31 8:39 ` [patch] VMX Unrestricted " Avi Kivity
2009-06-01 18:06 ` Nitin A Kamble [this message]
2009-06-01 18:35 ` Nitin A Kamble
2009-06-01 18:38 ` Avi Kivity
2009-06-03 18:08 ` Nitin A Kamble
2009-06-03 18:18 ` Nitin A Kamble
2009-06-03 18:20 ` Avi Kivity
2009-06-04 18:13 ` Jan Kiszka
2009-05-31 15:23 ` Anthony Liguori
2009-05-31 16:01 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243879609.30052.1.camel@mukti.sc.intel.com \
--to=nitin.a.kamble@intel.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox