Re: [patch] VMX Unrestricted mode support

Nitin A Kamble
2009-06-01T18:06:48Z

On Sun, 2009-05-31 at 01:39 -0700, Avi Kivity wrote:

> Thanks, this is much needed. Review comments below.
>

> Please avoid hiding computations in macros. Just change the call sites.

> Instead of changing all the checks like this, you can make rmode.active
> be false when unrestricted guest is enabled. We can interpret
> rmode.active as "emulating real mode via vm86", not as "guest is in real
> mode".
>
> You can just have enter_rmode() exit immediately when called.
>
> I think this can go away if rmode.active == 0.
>

Avi,
Thanks for your comments. I will cook another patch for this feature
as per your comments.

Thanks & Regards,
Nitin