From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: autotest@test.kernel.org
Cc: kvm@vger.kernel.org, Lucas Meneghel Rodrigues <lmr@redhat.com>,
Michael Goldish <mgoldish@redhat.com>
Subject: [KVM-AUTOTEST PATCH 5/8] stepeditor.py: get rid of some shortcuts
Date: Fri, 5 Jun 2009 17:46:31 -0300 [thread overview]
Message-ID: <1244234794-7844-6-git-send-email-lmr@redhat.com> (raw)
In-Reply-To: <1244234794-7844-5-git-send-email-lmr@redhat.com>
Disable a few keyboard shortcuts that were initially assumed to be useful,
but apparently override the default functionality of the involved keys
(e.g. 'home', 'end', 'delete') regardless of the widget that has the keyboard
focus.
Also make some indentation changes to the UI description.
Signed-off-by: Michael Goldish <mgoldish@redhat.com>
---
client/tests/kvm/stepeditor.py | 63 +++++++++++++++++++---------------------
1 files changed, 30 insertions(+), 33 deletions(-)
diff --git a/client/tests/kvm/stepeditor.py b/client/tests/kvm/stepeditor.py
index f2ef1aa..9669200 100755
--- a/client/tests/kvm/stepeditor.py
+++ b/client/tests/kvm/stepeditor.py
@@ -858,27 +858,27 @@ class StepMakerWindow:
class StepEditor(StepMakerWindow):
ui = '''<ui>
<menubar name="MenuBar">
- <menu action="File">
- <menuitem action="Open"/>
- <separator/>
- <menuitem action="Quit"/>
- </menu>
- <menu action="Edit">
- <menuitem action="CopyStep"/>
- <menuitem action="DeleteStep"/>
- </menu>
- <menu action="Insert">
- <menuitem action="InsertNewBefore"/>
- <menuitem action="InsertNewAfter"/>
- <separator/>
- <menuitem action="InsertStepsBefore"/>
- <menuitem action="InsertStepsAfter"/>
- </menu>
- <menu action="Tools">
- <menuitem action="CleanUp"/>
- </menu>
+ <menu action="File">
+ <menuitem action="Open"/>
+ <separator/>
+ <menuitem action="Quit"/>
+ </menu>
+ <menu action="Edit">
+ <menuitem action="CopyStep"/>
+ <menuitem action="DeleteStep"/>
+ </menu>
+ <menu action="Insert">
+ <menuitem action="InsertNewBefore"/>
+ <menuitem action="InsertNewAfter"/>
+ <separator/>
+ <menuitem action="InsertStepsBefore"/>
+ <menuitem action="InsertStepsAfter"/>
+ </menu>
+ <menu action="Tools">
+ <menuitem action="CleanUp"/>
+ </menu>
</menubar>
- </ui>'''
+</ui>'''
# Constructor
@@ -896,7 +896,7 @@ class StepEditor(StepMakerWindow):
self.window.add_accel_group(accelgroup)
# Create an ActionGroup
- actiongroup = gtk.ActionGroup('UIManagerExample')
+ actiongroup = gtk.ActionGroup('StepEditor')
# Create actions
actiongroup.add_actions([
@@ -904,22 +904,22 @@ class StepEditor(StepMakerWindow):
self.quit),
('Open', gtk.STOCK_OPEN, '_Open', None, 'Open steps file',
self.open_steps_file),
- ('CopyStep', gtk.STOCK_COPY, '_Copy current step...', None,
+ ('CopyStep', gtk.STOCK_COPY, '_Copy current step...', "",
'Copy current step to user specified position', self.copy_step),
- ('DeleteStep', gtk.STOCK_DELETE, '_Delete current step', None,
+ ('DeleteStep', gtk.STOCK_DELETE, '_Delete current step', "",
'Delete current step', self.event_remove_clicked),
- ('InsertNewBefore', gtk.STOCK_ADD, '_New step before current', None,
+ ('InsertNewBefore', gtk.STOCK_ADD, '_New step before current', "",
'Insert new step before current step', self.insert_before),
- ('InsertNewAfter', gtk.STOCK_ADD, 'N_ew step after current', None,
+ ('InsertNewAfter', gtk.STOCK_ADD, 'N_ew step after current', "",
'Insert new step after current step', self.insert_after),
('InsertStepsBefore', gtk.STOCK_ADD, '_Steps before current...',
- None, 'Insert steps (from file) before current step',
+ "", 'Insert steps (from file) before current step',
self.insert_steps_before),
- ('InsertStepsAfter', gtk.STOCK_ADD, 'Steps _after current...',
- None, 'Insert steps (from file) after current step',
+ ('InsertStepsAfter', gtk.STOCK_ADD, 'Steps _after current...', "",
+ 'Insert steps (from file) after current step',
self.insert_steps_after),
- ('CleanUp', gtk.STOCK_DELETE, '_Clean up data directory',
- None, 'Move unused PPM files to a backup directory', self.cleanup),
+ ('CleanUp', gtk.STOCK_DELETE, '_Clean up data directory', "",
+ 'Move unused PPM files to a backup directory', self.cleanup),
('File', None, '_File'),
('Edit', None, '_Edit'),
('Insert', None, '_Insert'),
@@ -939,9 +939,6 @@ class StepEditor(StepMakerWindow):
create_shortcut("Next", self.event_next_clicked, "Page_Down")
create_shortcut("Previous", self.event_prev_clicked, "Page_Up")
- create_shortcut("First", self.event_first_clicked, "Home")
- create_shortcut("Last", self.event_last_clicked, "End")
- create_shortcut("Delete", self.event_remove_clicked, "Delete")
# Add the actiongroup to the uimanager
uimanager.insert_action_group(actiongroup, 0)
--
1.6.2.2
next prev parent reply other threads:[~2009-06-05 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 20:46 [KVM-AUTOTEST PATCH 0/8] Re-submitting some of the patches on the patch queue Lucas Meneghel Rodrigues
2009-06-05 20:46 ` [KVM-AUTOTEST PATCH 1/8] kvm_config: Allow for "=" in the value of a config parameter Lucas Meneghel Rodrigues
2009-06-05 20:46 ` [KVM-AUTOTEST PATCH 2/8] RHEL-4.7 step files: fix the initial boot barriers Lucas Meneghel Rodrigues
2009-06-05 20:46 ` [KVM-AUTOTEST PATCH 3/8] WinXP step file fixes Lucas Meneghel Rodrigues
2009-06-05 20:46 ` [KVM-AUTOTEST PATCH 4/8] RHEL 5.3 " Lucas Meneghel Rodrigues
2009-06-05 20:46 ` Lucas Meneghel Rodrigues [this message]
2009-06-05 20:46 ` [KVM-AUTOTEST PATCH 6/8] Choose a monitor filename in the constructor of VM class Lucas Meneghel Rodrigues
2009-06-05 20:46 ` [KVM-AUTOTEST PATCH 7/8] Add new function, VM.clone() to clone an existing VM Lucas Meneghel Rodrigues
2009-06-05 20:46 ` [KVM-AUTOTEST PATCH 8/8] kvm_runtest_2.py: use pickle instead of shelve when loading/saving env Lucas Meneghel Rodrigues
2009-06-08 15:21 ` Lucas Meneghel Rodrigues
2009-06-08 16:10 ` [Autotest] " Martin Bligh
2009-06-08 16:54 ` Lucas Meneghel Rodrigues
2009-06-08 15:20 ` [KVM-AUTOTEST PATCH 7/8] Add new function, VM.clone() to clone an existing VM Lucas Meneghel Rodrigues
-- strict thread matches above, loose matches on Subject: below --
2009-06-08 4:01 [KVM-AUTOTEST PATCH 0/8] Re-submitting some of the patches on the patch queue Lucas Meneghel Rodrigues
2009-06-08 4:01 ` [KVM-AUTOTEST PATCH 1/8] kvm_config: Allow for "=" in the value of a config parameter Lucas Meneghel Rodrigues
2009-06-08 4:01 ` [PATCH 1/3] Make possible to use kvm_config as a standalone program Lucas Meneghel Rodrigues
2009-06-08 4:01 ` [PATCH 2/3] Fixing bad line breaks Lucas Meneghel Rodrigues
2009-06-08 4:01 ` [KVM-AUTOTEST PATCH 2/8] RHEL-4.7 step files: fix the initial boot barriers Lucas Meneghel Rodrigues
2009-06-08 4:01 ` [PATCH 3/3] Fix bad logging calls Lucas Meneghel Rodrigues
2009-06-08 4:01 ` [KVM-AUTOTEST PATCH 3/8] WinXP step file fixes Lucas Meneghel Rodrigues
2009-06-08 4:01 ` [KVM-AUTOTEST PATCH 4/8] RHEL 5.3 " Lucas Meneghel Rodrigues
2009-06-08 4:01 ` [KVM-AUTOTEST PATCH 5/8] stepeditor.py: get rid of some shortcuts Lucas Meneghel Rodrigues
2009-06-08 15:19 ` Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244234794-7844-6-git-send-email-lmr@redhat.com \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox