public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Uri Lublin <uril@redhat.com>
Cc: KVM List <kvm@vger.kernel.org>, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [git pull request] kvm-autotest: sync with upstream Autotest SVN
Date: Mon, 08 Jun 2009 01:01:32 -0300	[thread overview]
Message-ID: <1244433692.2666.1.camel@localhost.localdomain> (raw)
In-Reply-To: <4A2B8323.7080401@redhat.com>

Hi Uri!

Thank you very much, I've identified the problems you mentioned and made
patches to fix them. They will follow shortly.

On Sun, 2009-06-07 at 12:06 +0300, Uri Lublin wrote:
> Hello,
> 
> I ran some tests using the newly merged kvm-autotest.
> Results summary: 148 tests passed (out of 250)
> 
> Following are some things that got broken in the merge, which are easy to fix:
> 1. kvm_config.py as a stand-alone program.
>     - please do not throw autotest-exceptions (such as error.TestError) in this 
> file.
> 2. make_html_report.py
>     - missing \ at the end of quoted line. An example is:
>       The code:
>           a = "first value %s second value %d" % (val1 ,val2)
>       Was replace with:
>           a = "first value %s"
>           "second value %d" % (val1, val2)
>       The second line is broken.
>       To fix just add \ at the end of the first line (+ indentation).
> 
> 3.  Running autotest tests on KVM guests:
>      Same problem as in make_html_report above.
> 
> 4. Change to python logging: (at least in kvm_utils.py)
>     need to replace logging.debug(msg, additional_string) with logging.debug(msg 
> + additional_string)
> 
> Regards,
>      Uri
> 


-- 
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies


      reply	other threads:[~2009-06-08  4:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-01 20:41 [git pull request] kvm-autotest: sync with upstream Autotest SVN Eduardo Habkost
2009-06-03 17:50 ` Uri Lublin
2009-06-07  9:06 ` Uri Lublin
2009-06-08  4:01   ` Lucas Meneghel Rodrigues [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244433692.2666.1.camel@localhost.localdomain \
    --to=lmr@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=uril@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox