From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [git pull request] kvm-autotest: sync with upstream Autotest
 SVN
Date: Mon, 08 Jun 2009 01:01:32 -0300
Message-ID: <1244433692.2666.1.camel@localhost.localdomain>
References: <20090601204108.GL4223@blackpad>  <4A2B8323.7080401@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: KVM List <kvm@vger.kernel.org>,
	Eduardo Habkost <ehabkost@redhat.com>
To: Uri Lublin <uril@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:59261 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750698AbZFHEBe (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 8 Jun 2009 00:01:34 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5841aL6027306
	for <kvm@vger.kernel.org>; Mon, 8 Jun 2009 00:01:36 -0400
In-Reply-To: <4A2B8323.7080401@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Uri!

Thank you very much, I've identified the problems you mentioned and made
patches to fix them. They will follow shortly.

On Sun, 2009-06-07 at 12:06 +0300, Uri Lublin wrote:
> Hello,
> 
> I ran some tests using the newly merged kvm-autotest.
> Results summary: 148 tests passed (out of 250)
> 
> Following are some things that got broken in the merge, which are easy to fix:
> 1. kvm_config.py as a stand-alone program.
>     - please do not throw autotest-exceptions (such as error.TestError) in this 
> file.
> 2. make_html_report.py
>     - missing \ at the end of quoted line. An example is:
>       The code:
>           a = "first value %s second value %d" % (val1 ,val2)
>       Was replace with:
>           a = "first value %s"
>           "second value %d" % (val1, val2)
>       The second line is broken.
>       To fix just add \ at the end of the first line (+ indentation).
> 
> 3.  Running autotest tests on KVM guests:
>      Same problem as in make_html_report above.
> 
> 4. Change to python logging: (at least in kvm_utils.py)
>     need to replace logging.debug(msg, additional_string) with logging.debug(msg 
> + additional_string)
> 
> Regards,
>      Uri
> 


-- 
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies