From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: [PATCH 2/2] KVM: Prevent overflow in largepages calculation Date: Mon, 8 Jun 2009 16:00:10 +0300 Message-ID: <1244466010-24909-3-git-send-email-avi@redhat.com> References: <1244466010-24909-1-git-send-email-avi@redhat.com> Cc: Marcelo Tosatti To: kvm@vger.kernel.org Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54667 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754692AbZFHNAL (ORCPT ); Mon, 8 Jun 2009 09:00:11 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n58D0EBc006565 for ; Mon, 8 Jun 2009 09:00:14 -0400 In-Reply-To: <1244466010-24909-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: If userspace specifies a memory slot that is larger than 8 petabytes, it could overflow the largepages variable. Signed-off-by: Avi Kivity --- virt/kvm/kvm_main.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index b9ca73c..669eb4a 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1087,8 +1087,7 @@ int __kvm_set_memory_region(struct kvm *kvm, int r; gfn_t base_gfn; unsigned long npages, ugfn; - int largepages; - unsigned long i; + unsigned long largepages, i; struct kvm_memory_slot *memslot; struct kvm_memory_slot old, new; -- 1.6.0.6