From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Martin Bligh <mbligh@google.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [Autotest] [KVM-AUTOTEST PATCH 1/4] Make all programs on kvm test use /usr/bin/python
Date: Tue, 09 Jun 2009 21:59:31 -0300 [thread overview]
Message-ID: <1244595571.13989.0.camel@localhost.localdomain> (raw)
In-Reply-To: <33307c790906091000v26c7a9f2qd06dcaf9de4b047a@mail.gmail.com>
On Tue, 2009-06-09 at 10:00 -0700, Martin Bligh wrote:
> I'd suggest you use the same mechanism as the other entry points,
> and override the python version where necessary - some distros
> have ancient or bleeding edge default Python versions.
>
> see common.py -> setup_modules.py -> check_version.check_python_version
Done. Re-sent the patch of the stand alone programs. Thanks!
> On Tue, Jun 9, 2009 at 9:33 AM, Lucas Meneghel Rodrigues<lmr@redhat.com> wrote:
> > All kvm modules that can be used as stand alone programs were
> > updated to use #!/usr/bin/python instead of #!/usr/bin/env python,
> > complying with the rest of the autotest code base.
> >
> > Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
> > ---
> > client/tests/kvm/fix_cdkeys.py | 2 +-
> > client/tests/kvm/kvm_config.py | 1 +
> > client/tests/kvm/scan_results.py | 2 +-
> > client/tests/kvm/stepeditor.py | 2 +-
> > client/tests/kvm/stepmaker.py | 2 +-
> > 5 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/client/tests/kvm/fix_cdkeys.py b/client/tests/kvm/fix_cdkeys.py
> > index 4f7a824..7f52c44 100755
> > --- a/client/tests/kvm/fix_cdkeys.py
> > +++ b/client/tests/kvm/fix_cdkeys.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/python
> > import shutil, os, sys
> >
> > """
> > diff --git a/client/tests/kvm/kvm_config.py b/client/tests/kvm/kvm_config.py
> > index 40f16f1..a3467a0 100755
> > --- a/client/tests/kvm/kvm_config.py
> > +++ b/client/tests/kvm/kvm_config.py
> > @@ -1,3 +1,4 @@
> > +#!/usr/bin/python
> > import re, os, sys, StringIO
> > from autotest_lib.client.common_lib import error
> >
> > diff --git a/client/tests/kvm/scan_results.py b/client/tests/kvm/scan_results.py
> > index 156b7d4..a92c867 100755
> > --- a/client/tests/kvm/scan_results.py
> > +++ b/client/tests/kvm/scan_results.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/python
> > """
> > Program that parses the autotest results and return a nicely printed final test
> > result.
> > diff --git a/client/tests/kvm/stepeditor.py b/client/tests/kvm/stepeditor.py
> > index 9669200..6fb371b 100755
> > --- a/client/tests/kvm/stepeditor.py
> > +++ b/client/tests/kvm/stepeditor.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/python
> > import pygtk, gtk, os, glob, shutil, sys, logging
> > import ppm_utils
> > pygtk.require('2.0')
> > diff --git a/client/tests/kvm/stepmaker.py b/client/tests/kvm/stepmaker.py
> > index 2b7fd54..a9ddf25 100644
> > --- a/client/tests/kvm/stepmaker.py
> > +++ b/client/tests/kvm/stepmaker.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/python
> > import pygtk, gtk, gobject, time, os, commands
> > from autotest_lib.client.common_lib import error
> > import kvm_utils, logging, ppm_utils, stepeditor
> > --
> > 1.6.2.2
> >
> > _______________________________________________
> > Autotest mailing list
> > Autotest@test.kernel.org
> > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
> >
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies
next prev parent reply other threads:[~2009-06-10 0:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 16:33 [KVM-AUTOTEST PATCH 1/4] Make all programs on kvm test use /usr/bin/python Lucas Meneghel Rodrigues
2009-06-09 16:33 ` [KVM-AUTOTEST PATCH 2/4] Make kvm_config.py to use internal/standard exeptions Lucas Meneghel Rodrigues
2009-06-09 16:33 ` [KVM-AUTOTEST PATCH 3/4] Fix bad line breaks Lucas Meneghel Rodrigues
2009-06-09 16:33 ` [KVM-AUTOTEST PATCH 4/4] Fix bad logging calls Lucas Meneghel Rodrigues
2009-06-10 12:32 ` [KVM-AUTOTEST PATCH 3/4] Fix bad line breaks Michael Goldish
2009-06-10 12:21 ` [Autotest] [KVM-AUTOTEST PATCH 2/4] Make kvm_config.py to use internal/standard exeptions Michael Goldish
2009-06-10 12:36 ` Michael Goldish
2009-06-09 17:00 ` [Autotest] [KVM-AUTOTEST PATCH 1/4] Make all programs on kvm test use /usr/bin/python Martin Bligh
2009-06-10 0:59 ` Lucas Meneghel Rodrigues [this message]
2009-06-10 11:01 ` Alexey Eromenko
2009-06-10 14:19 ` Martin Bligh
2009-06-15 13:35 ` Alexey Eromenko
2009-06-15 14:41 ` Lucas Meneghel Rodrigues
2009-06-15 15:58 ` Martin Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244595571.13989.0.camel@localhost.localdomain \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mbligh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox