From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [KVM-AUTOTEST PATCH 02/06] kvm_runtest_2.py: Use env filename specified by the 'env' parameter Date: Wed, 10 Jun 2009 16:29:20 -0300 Message-ID: <1244662160.22524.12.camel@localhost.localdomain> References: <1244507691-9575-1-git-send-email-lmr@redhat.com> <1244507691-9575-2-git-send-email-lmr@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Michael Goldish To: autotest@test.kernel.org Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39607 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753648AbZFJT3U (ORCPT ); Wed, 10 Jun 2009 15:29:20 -0400 In-Reply-To: <1244507691-9575-2-git-send-email-lmr@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2009-06-08 at 21:34 -0300, Lucas Meneghel Rodrigues wrote: > Do not use hardcoded environment filename 'env'. Instead use the value > specified by the 'env' parameter. If unspecified, use 'env' as the > filename. > > This is important for parallel execution; it may be necessary to use a > separate > environment file for each process. Applied, thanks! > Signed-off-by: Michael Goldish > --- > client/tests/kvm/kvm.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py > index a658425..9428162 100644 > --- a/client/tests/kvm/kvm.py > +++ b/client/tests/kvm/kvm.py > @@ -82,7 +82,7 @@ class kvm(test.test): > self.write_test_keyval({key: params[key]}) > > # Open the environment file > - env_filename = os.path.join(self.bindir, "env") > + env_filename = os.path.join(self.bindir, params.get("env", "env")) > env = load_env(env_filename, {}) > logging.debug("Contents of environment: %s" % str(env)) > -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies