From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [KVM-AUTOTEST PATCH 03/06] kvm_vm.py: add new VM parameter
 'x11_display' that controls $DISPLAY
Date: Wed, 10 Jun 2009 16:29:33 -0300
Message-ID: <1244662173.22524.13.camel@localhost.localdomain>
References: <1244507691-9575-1-git-send-email-lmr@redhat.com>
	 <1244507691-9575-2-git-send-email-lmr@redhat.com>
	 <1244507691-9575-3-git-send-email-lmr@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Michael Goldish <mgoldish@redhat.com>
To: autotest@test.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:39622 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756045AbZFJT3d (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 10 Jun 2009 15:29:33 -0400
In-Reply-To: <1244507691-9575-3-git-send-email-lmr@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2009-06-08 at 21:34 -0300, Lucas Meneghel Rodrigues wrote:
> If x11_display is specified, the DISPLAY environment variable
> is set to this value for the QEMU process. This may be useful
> for SDL rendering. Also add some comments.

Applied, thanks!

> Signed-off-by: Michael Goldish <mgoldish@redhat.com>
> ---
>  client/tests/kvm/kvm_vm.py |   13 ++++++++++++-
>  1 files changed, 12 insertions(+), 1 deletions(-)
> 
> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
> index e2b684c..6de3989 100644
> --- a/client/tests/kvm/kvm_vm.py
> +++ b/client/tests/kvm/kvm_vm.py
> @@ -196,6 +196,9 @@ class VM:
>                 (iso_dir is pre-pended to the ISO filename)
>                 extra_params -- a string to append to the qemu command
>                 ssh_port -- should be 22 for SSH, 23 for Telnet
> +               x11_display -- if specified, the DISPLAY environment variable
> +               will be be set to this value for the qemu process (useful for
> +               SDL rendering)
>                 images -- a list of image object names, separated by spaces
>                 nics -- a list of NIC object names, separated by spaces
>  
> @@ -222,8 +225,16 @@ class VM:
>          if iso_dir == None:
>              iso_dir = self.iso_dir
>  
> -        qemu_cmd = qemu_path
> +        # Start constructing the qemu command
> +        qemu_cmd = ""
> +        # Set the X11 display parameter if requested
> +        if params.get("x11_display"):
> +            qemu_cmd += "DISPLAY=%s " % params.get("x11_display")
> +        # Add the qemu binary
> +        qemu_cmd += qemu_path
> +        # Add the VM's name
>          qemu_cmd += " -name '%s'" % name
> +        # Add the monitor socket parameter
>          qemu_cmd += " -monitor unix:%s,server,nowait" % self.monitor_file_name
>  
>          for image_name in kvm_utils.get_sub_dict_names(params, "images"):
-- 
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies