From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [KVM-AUTOTEST PATCH 04/06] VM.create(): always destroy() the
 VM before attempting to start it
Date: Wed, 10 Jun 2009 16:29:49 -0300
Message-ID: <1244662189.22524.14.camel@localhost.localdomain>
References: <1244507691-9575-1-git-send-email-lmr@redhat.com>
	 <1244507691-9575-2-git-send-email-lmr@redhat.com>
	 <1244507691-9575-3-git-send-email-lmr@redhat.com>
	 <1244507691-9575-4-git-send-email-lmr@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Michael Goldish <mgoldish@redhat.com>
To: autotest@test.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:39636 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756603AbZFJT3t (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 10 Jun 2009 15:29:49 -0400
In-Reply-To: <1244507691-9575-4-git-send-email-lmr@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2009-06-08 at 21:34 -0300, Lucas Meneghel Rodrigues wrote:
> Also, don't do it in kvm_preprocessing.py since it's now done in
> kvm_vm.py.

Applied, thanks!

> Signed-off-by: Michael Goldish <mgoldish@redhat.com>
> ---
>  client/tests/kvm/kvm_preprocessing.py |    1 -
>  client/tests/kvm/kvm_vm.py            |    2 ++
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py
> index e395d98..f60cfe8 100644
> --- a/client/tests/kvm/kvm_preprocessing.py
> +++ b/client/tests/kvm/kvm_preprocessing.py
> @@ -80,7 +80,6 @@ def preprocess_vm(test, params, env, name):
>              start_vm = True
>  
>      if start_vm:
> -        vm.destroy()
>          if not vm.create(name, params, qemu_path, image_dir, iso_dir,
>                           for_migration):
>              message = "Could not start VM"
> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
> index 6de3989..d7b0735 100644
> --- a/client/tests/kvm/kvm_vm.py
> +++ b/client/tests/kvm/kvm_vm.py
> @@ -303,6 +303,8 @@ class VM:
>          @param for_migration: If True, start the VM with the -incoming
>          option
>          """
> +        self.destroy()
> +
>          if name != None:
>              self.name = name
>          if params != None:
-- 
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies