public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH 7/8] s->cpu_env cannot be zero here.
Date: Mon, 15 Jun 2009 16:23:16 +0300	[thread overview]
Message-ID: <1245072197-7538-8-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1245072197-7538-1-git-send-email-gleb@redhat.com>

Remove redundant check.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
 hw/apic.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/hw/apic.c b/hw/apic.c
index f186202..eac54fd 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -471,8 +471,7 @@ static void apic_init_ipi(APICState *s)
         s->cpu_env->halted = 1;
 
     if (kvm_enabled() && !qemu_kvm_irqchip_in_kernel())
-	if (s->cpu_env)
-	    kvm_apic_init(s->cpu_env);
+        kvm_apic_init(s->cpu_env);
 }
 
 /* send a SIPI message to the CPU to start it */
-- 
1.6.2.1


  parent reply	other threads:[~2009-06-15 13:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 13:23 [PATCH 0/8] Small cpu loop cleanups Gleb Natapov
2009-06-15 13:23 ` [PATCH 1/8] env->kvm_cpu_state.init is always zero here Gleb Natapov
2009-06-15 13:23 ` [PATCH 2/8] Do not use env->halted to decide where halted state should be handled Gleb Natapov
2009-06-15 13:23 ` [PATCH 3/8] Call kvm_arch_load_regs() instead of kvm_load_registers() Gleb Natapov
2009-06-15 13:23 ` [PATCH 4/8] Rename kvm_(load|save)_mpstate to kvm_arch_(load|save)_mpstate Gleb Natapov
2009-06-15 13:23 ` [PATCH 5/8] Retrieve mp state info in cpu_synchronize_state() Gleb Natapov
2009-06-15 13:23 ` [PATCH 6/8] env->exception_index is not used by kvm code Gleb Natapov
2009-06-15 13:23 ` Gleb Natapov [this message]
2009-06-15 13:23 ` [PATCH 8/8] env->exit_request is not used by kvm Gleb Natapov
2009-06-15 13:51 ` [PATCH 0/8] Small cpu loop cleanups Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245072197-7538-8-git-send-email-gleb@redhat.com \
    --to=gleb@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox