From: Glauber Costa <glommer@redhat.com>
To: kvm@vger.kernel.org
Cc: avi@redhat.com, Hollis Blanchard <hollisb@us.ibm.com>
Subject: [PATCH] remove ppc functions from callbacks
Date: Tue, 16 Jun 2009 09:34:52 -0400 [thread overview]
Message-ID: <1245159292-7579-1-git-send-email-glommer@redhat.com> (raw)
handle_powerpc_dcr_read() and handle_powerpc_dcr_write() are two
powerpc specific functions that are called via libkvm callbacks.
However, grepping the source code finds simply no use of them. This
is probably due to the fact that powerpc now relies on a totally
qemu upstream implementation of kvm, and does not need it anymore.
Anyway, I'm providing this patch separatedly, so that if it breaks
for whenever reason, we can identify a bisection point easily
Signed-off-by: Glauber Costa <glommer@redhat.com>
CC: Hollis Blanchard <hollisb@us.ibm.com>
---
libkvm-all.h | 4 ----
qemu-kvm.c | 4 ----
qemu-kvm.h | 5 -----
3 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/libkvm-all.h b/libkvm-all.h
index 4f7b9a3..47855be 100644
--- a/libkvm-all.h
+++ b/libkvm-all.h
@@ -156,10 +156,6 @@ struct kvm_callbacks {
void (*post_kvm_run)(void *opaque, void *env);
int (*pre_kvm_run)(void *opaque, void *env);
int (*tpr_access)(void *opaque, kvm_vcpu_context_t vcpu, uint64_t rip, int is_write);
-#if defined(__powerpc__)
- int (*powerpc_dcr_read)(kvm_vcpu_context_t vcpu, uint32_t dcrn, uint32_t *data);
- int (*powerpc_dcr_write)(kvm_vcpu_context_t vcpu, uint32_t dcrn, uint32_t data);
-#endif
#if defined(__s390__)
int (*s390_handle_intercept)(kvm_context_t context, kvm_vcpu_context_t vcpu,
struct kvm_run *run);
diff --git a/qemu-kvm.c b/qemu-kvm.c
index eefca61..61f5a19 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -2278,10 +2278,6 @@ static struct kvm_callbacks qemu_kvm_ops = {
#ifdef TARGET_I386
.tpr_access = handle_tpr_access,
#endif
-#ifdef TARGET_PPC
- .powerpc_dcr_read = handle_powerpc_dcr_read,
- .powerpc_dcr_write = handle_powerpc_dcr_write,
-#endif
.unhandled = handle_unhandled,
};
diff --git a/qemu-kvm.h b/qemu-kvm.h
index 126b8f3..57e8a2f 100644
--- a/qemu-kvm.h
+++ b/qemu-kvm.h
@@ -134,11 +134,6 @@ void kvm_remove_ioperm_data(unsigned long start_port, unsigned long num);
void kvm_arch_do_ioperm(void *_data);
#endif
-#ifdef TARGET_PPC
-int handle_powerpc_dcr_read(kvm_vcpu_context_t vcpu, uint32_t dcrn, uint32_t *data);
-int handle_powerpc_dcr_write(kvm_vcpu_context_t vcpu,uint32_t dcrn, uint32_t data);
-#endif
-
#define ALIGN(x, y) (((x)+(y)-1) & ~((y)-1))
#define BITMAP_SIZE(m) (ALIGN(((m)>>TARGET_PAGE_BITS), HOST_LONG_BITS) / 8)
--
1.6.2.2
next reply other threads:[~2009-06-16 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 13:34 Glauber Costa [this message]
2009-06-16 14:54 ` [PATCH] remove ppc functions from callbacks Hollis Blanchard
2009-06-18 9:08 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245159292-7579-1-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox