From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3
 03/13] qemu: add routines to manage PCI capabilities]
Date: Wed, 17 Jun 2009 10:18:03 +0100
Message-ID: <1245230283.27028.36.camel@blaa>
References: <4A364FE0.40204@redhat.com> <4A3651EB.3070204@codemonkey.ws>
	 <4A36555A.4090303@redhat.com> <4A3659A0.3050108@codemonkey.ws>
	 <4A366348.1030202@redhat.com> <1245083229.3222.103.camel@blaa>
	 <4A368F12.2090504@codemonkey.ws> <1245154451.11407.22.camel@blaa>
	 <4A378FE5.5050303@redhat.com> <1245155992.30082.8.camel@blaa>
	 <20090616184404.GJ11893@shareable.org> <1245227632.27028.29.camel@blaa>
	 <4A38B147.1030207@redhat.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Jamie Lokier <jamie@shareable.org>,
	Carsten Otte <cotte@de.ibm.com>, dlaor@redhat.com,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Glauber Costa <glommer@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org,
	Blue Swirl <blauwirbel@gmail.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Paul Brook <paul@codesourcery.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:54025 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755888AbZFQJUw (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 17 Jun 2009 05:20:52 -0400
In-Reply-To: <4A38B147.1030207@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 2009-06-17 at 12:03 +0300, Avi Kivity wrote:
> On 06/17/2009 11:33 AM, Mark McLoughlin wrote:
> >> I particularly don't like the idea of arcane machine-dependent slot
> >> allocation knowledge living in libvirt, because it needs to be in Qemu
> >> anyway for non-libvirt users.  No point in having two implementations
> >> of something tricky and likely to have machine quirks, if one will do.
> >
> > Indeed.
> 
> I don't understand this.

Take note of the "arcane machine-dependent slot allocation knowledge"
bit.

If the algorithm in for management apps is as simple as "query qemu for
available slots and sequentially allocate slots", then that's perfectly
fine.

If management apps need to hard-code which slots are available on
different targets and different qemu versions, or restrictions on which
devices can use which slots, or knowledge that some devices can be
multi-function, or ... anything like that is just lame.

Cheers,
Mark.