From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [KVM-AUTOTEST PATCH 1/2] KVM test: optionally convert PPM files to PNG format after test Date: Thu, 18 Jun 2009 06:08:39 -0300 Message-ID: <1245316119.11036.28.camel@freedom> References: <2839fd912f78bbd89777f6da5f09480946809ac0.1245149801.git.mgoldish@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51933 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbZFRJIk (ORCPT ); Thu, 18 Jun 2009 05:08:40 -0400 In-Reply-To: <2839fd912f78bbd89777f6da5f09480946809ac0.1245149801.git.mgoldish@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2009-06-16 at 14:00 +0300, Michael Goldish wrote: > This is intended to save disk space. Requires ImageMagick (uses mogrify). > > To enable: > convert_ppm_files_to_png = yes > > To enable only for failed tests: > convert_ppm_files_to_png_on_error = yes > > Reminder: by default PPM files are removed after the test (and after the > conversion, if requested). To keep them specify: > keep_ppm_files = yes > > To keep them only for failed tests: > keep_ppm_files_on_error = yes > > A reasonable choice would be to keep PNG files for failed tests, and never > keep PPM files. To do this specify > convert_ppm_files_to_png_on_error = yes > without specifying 'keep_ppm_files = yes' or 'keep_ppm_files_on_error = yes' > (or explicitly set to 'no', if it was set to 'yes' on a higher level in the > config hierarchy). > > This patch also makes small cosmetic changes to the 'keep_ppm_files' feature. Forgot to say that other than performing a check to see if we actually do have ImageMagick before trying to convert the images, the patch series looks good, once you get this worked out I am going to apply it. -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies