From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [KVM-AUTOTEST PATCH 0/4] Step file tests: introducing a new feature and some small changes
Date: Thu, 18 Jun 2009 11:40:54 -0300 [thread overview]
Message-ID: <1245336054.16589.10.camel@freedom> (raw)
In-Reply-To: <1245095119-29942-1-git-send-email-mgoldish@redhat.com>
On Mon, 2009-06-15 at 22:45 +0300, Michael Goldish wrote:
> The following patches make some changes to step file tests:
> * Rename parameter output_dir in barrier_2() to debug_dir.
> * Move some code from run_steps() into barrier_2().
> * Add a new feature (keep_screendump_history) which allows the user to see
> exactly what went wrong with a step file test. Currently only the last
> screendump is kept for each failed step file test; with this feature enabled,
> all screendumps are kept in compact JPG format.
> * Use the new feature by default in kvm_tests.cfg.sample.
>
Other than minor comments, patch set looks good to me. Please let me
know if you agree with my comments.
--
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies
prev parent reply other threads:[~2009-06-18 14:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 19:45 [KVM-AUTOTEST PATCH 0/4] Step file tests: introducing a new feature and some small changes Michael Goldish
2009-06-15 19:45 ` [KVM-AUTOTEST PATCH 1/4] kvm_guest_wizard: rename output_dir to debug_dir in barrier_2() Michael Goldish
2009-06-15 19:45 ` [KVM-AUTOTEST PATCH 2/4] kvm_guest_wizard: pass 'params' directly to barrier_2() Michael Goldish
2009-06-16 14:57 ` Uri Lublin
2009-06-15 19:45 ` [KVM-AUTOTEST PATCH 3/4] kvm_guest_wizard: allow keeping screendump history for debugging purposes Michael Goldish
2009-06-18 14:30 ` [Autotest] " Lucas Meneghel Rodrigues
2009-06-18 15:30 ` Michael Goldish
2009-06-15 19:45 ` [KVM-AUTOTEST PATCH 4/4] kvm_tests.cfg.sample: add 'keep_screendump_history = yes' to step file tests Michael Goldish
2009-06-18 14:31 ` [Autotest] " Lucas Meneghel Rodrigues
2009-06-18 14:40 ` Lucas Meneghel Rodrigues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245336054.16589.10.camel@freedom \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox