From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [KVM-AUTOTEST PATCH 0/4] Step file tests: introducing a new feature and some small changes Date: Thu, 18 Jun 2009 11:40:54 -0300 Message-ID: <1245336054.16589.10.camel@freedom> References: <1245095119-29942-1-git-send-email-mgoldish@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45392 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757407AbZFROk4 (ORCPT ); Thu, 18 Jun 2009 10:40:56 -0400 In-Reply-To: <1245095119-29942-1-git-send-email-mgoldish@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2009-06-15 at 22:45 +0300, Michael Goldish wrote: > The following patches make some changes to step file tests: > * Rename parameter output_dir in barrier_2() to debug_dir. > * Move some code from run_steps() into barrier_2(). > * Add a new feature (keep_screendump_history) which allows the user to see > exactly what went wrong with a step file test. Currently only the last > screendump is kept for each failed step file test; with this feature enabled, > all screendumps are kept in compact JPG format. > * Use the new feature by default in kvm_tests.cfg.sample. > Other than minor comments, patch set looks good to me. Please let me know if you agree with my comments. -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies