From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: Alexey Eromenko <aeromenk@redhat.com>,
autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [Autotest] [KVM-AUTOTEST PATCH 1/2] KVM test: add shutdown test
Date: Thu, 18 Jun 2009 11:46:22 -0300 [thread overview]
Message-ID: <1245336382.16589.12.camel@freedom> (raw)
In-Reply-To: <777084539.82461245150303942.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
On Tue, 2009-06-16 at 07:05 -0400, Michael Goldish wrote:
> ----- "Alexey Eromenko" <aeromenk@redhat.com> wrote:
>
> > Michael I don't fully understand why shutdown test is needed; Shutdown
> > is tested during reboot, where GuestOS must de-init itself.
>
> The main motivation for a shutdown test is that it allows us to choose
> whether VMs should be kept alive after the last test. Including this test
> in a job takes no more time than running the job without it, because
> normally the preprocessor automatically shuts down guests (except for the
> last one).
>
> There's also a small difference between a complete shutdown and a reboot --
> a shutdown is supposed to close the qemu process. I'm not sure this
> difference justifies the test, but the reason mentioned in the previous
> paragraph does, in my opinion.
Fair enough, I agree. Will apply the patch.
--
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies
next prev parent reply other threads:[~2009-06-18 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 7:37 [KVM-AUTOTEST PATCH 1/2] KVM test: add shutdown test Michael Goldish
2009-06-16 7:37 ` [KVM-AUTOTEST PATCH 2/2] KVM test: include shutdown test in kvm_tests.cfg.sample Michael Goldish
2009-06-16 10:42 ` [KVM-AUTOTEST PATCH 1/2] KVM test: add shutdown test Alexey Eromenko
2009-06-16 11:05 ` Michael Goldish
2009-06-18 14:46 ` Lucas Meneghel Rodrigues [this message]
2009-06-17 3:10 ` jason wang
2009-06-18 15:06 ` [Autotest] " Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245336382.16589.12.camel@freedom \
--to=lmr@redhat.com \
--cc=aeromenk@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox