From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [Autotest] [KVM-AUTOTEST PATCH 1/2] KVM test: add shutdown test Date: Thu, 18 Jun 2009 11:46:22 -0300 Message-ID: <1245336382.16589.12.camel@freedom> References: <777084539.82461245150303942.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Alexey Eromenko , autotest@test.kernel.org, kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38117 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbZFROqY (ORCPT ); Thu, 18 Jun 2009 10:46:24 -0400 In-Reply-To: <777084539.82461245150303942.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2009-06-16 at 07:05 -0400, Michael Goldish wrote: > ----- "Alexey Eromenko" wrote: > > > Michael I don't fully understand why shutdown test is needed; Shutdown > > is tested during reboot, where GuestOS must de-init itself. > > The main motivation for a shutdown test is that it allows us to choose > whether VMs should be kept alive after the last test. Including this test > in a job takes no more time than running the job without it, because > normally the preprocessor automatically shuts down guests (except for the > last one). > > There's also a small difference between a complete shutdown and a reboot -- > a shutdown is supposed to close the qemu process. I'm not sure this > difference justifies the test, but the reason mentioned in the previous > paragraph does, in my opinion. Fair enough, I agree. Will apply the patch. -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies