public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Dustin Kirkland <kirkland@canonical.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
	Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [PATCH] Only compile KVM support for matching CPU types
Date: Wed, 24 Jun 2009 18:14:33 -0500	[thread overview]
Message-ID: <1245885273.4479.5.camel@t61p> (raw)
In-Reply-To: <1245884974.4479.1.camel@t61p>

[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]

On Wed, 2009-06-24 at 18:09 -0500, Dustin Kirkland wrote:
> On Wed, 2009-06-24 at 17:40 -0500, Anthony Liguori wrote:
> >  # Make sure the target and host cpus are compatible
> >  if test ! \( "$target_cpu" = "$cpu" -o \
> >    \( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \
> >    \( "$target_cpu" = "x86_64" -a "$cpu" = "i386"   \) -o \
> >    \( "$target_cpu" = "i386"   -a "$cpu" = "x86_64" \) \) ; then
> > +  \( "$target_cpu" = "ia64"   -a "$cpu" = "ia64" \) \) ; then
> 
> Almost...
> 
> -  \( "$target_cpu" = "i386"   -a "$cpu" = "x86_64" \) \) ; then
> +  \( "$target_cpu" = "i386"   -a "$cpu" = "x86_64" \) \) -o \
> +  \( "$target_cpu" = "ia64"   -a "$cpu" = "ia64" \) \) ; then

Doh.  Still not quite right...

Clean patch below.

Signed-off-by: Dustin Kirkland <kirkland@canonical.com>

=== modified file 'configure'
--- configure	2009-06-17 11:16:33 +0000
+++ configure	2009-06-24 23:13:00 +0000
@@ -2117,13 +2117,12 @@
   fi
 }
 
-if [ use_upstream_kvm = yes ]; then
-
 # Make sure the target and host cpus are compatible
 if test ! \( "$target_cpu" = "$cpu" -o \
   \( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \
   \( "$target_cpu" = "x86_64" -a "$cpu" = "i386"   \) -o \
-  \( "$target_cpu" = "i386"   -a "$cpu" = "x86_64" \) \) ; then
+  \( "$target_cpu" = "i386"   -a "$cpu" = "x86_64" \) -o \
+  \( "$target_cpu" = "ia64"   -a "$cpu" = "ia64" \) \) ; then
   target_kvm="no"
 fi
 # Disable KVM for linux-user
@@ -2131,8 +2130,6 @@
   target_kvm="no"
 fi
 
-fi
-
 case "$target_cpu" in
   i386)
     echo "TARGET_ARCH=i386" >> $config_mak



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-06-24 23:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 22:40 [PATCH] Only compile KVM support for matching CPU types Anthony Liguori
2009-06-24 23:09 ` Dustin Kirkland
2009-06-24 23:14   ` Dustin Kirkland [this message]
2009-06-24 23:29   ` Anthony Liguori
2009-06-28 14:03 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245885273.4479.5.camel@t61p \
    --to=kirkland@canonical.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=hollisb@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox