From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dustin Kirkland Subject: Re: [PATCH] Only compile KVM support for matching CPU types Date: Wed, 24 Jun 2009 18:14:33 -0500 Message-ID: <1245885273.4479.5.camel@t61p> References: <1245883217-27455-1-git-send-email-aliguori@us.ibm.com> <1245884974.4479.1.camel@t61p> Reply-To: kirkland@canonical.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-uzi6Mf03Z+BwDsr9WjUa" Cc: kvm@vger.kernel.org, Avi Kivity , Hollis Blanchard To: Anthony Liguori Return-path: Received: from adelie.canonical.com ([91.189.90.139]:34522 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbZFXXOe (ORCPT ); Wed, 24 Jun 2009 19:14:34 -0400 In-Reply-To: <1245884974.4479.1.camel@t61p> Sender: kvm-owner@vger.kernel.org List-ID: --=-uzi6Mf03Z+BwDsr9WjUa Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2009-06-24 at 18:09 -0500, Dustin Kirkland wrote: > On Wed, 2009-06-24 at 17:40 -0500, Anthony Liguori wrote: > > # Make sure the target and host cpus are compatible > > if test ! \( "$target_cpu" =3D "$cpu" -o \ > > \( "$target_cpu" =3D "ppcemb" -a "$cpu" =3D "ppc" \) -o \ > > \( "$target_cpu" =3D "x86_64" -a "$cpu" =3D "i386" \) -o \ > > \( "$target_cpu" =3D "i386" -a "$cpu" =3D "x86_64" \) \) ; then > > + \( "$target_cpu" =3D "ia64" -a "$cpu" =3D "ia64" \) \) ; then >=20 > Almost... >=20 > - \( "$target_cpu" =3D "i386" -a "$cpu" =3D "x86_64" \) \) ; then > + \( "$target_cpu" =3D "i386" -a "$cpu" =3D "x86_64" \) \) -o \ > + \( "$target_cpu" =3D "ia64" -a "$cpu" =3D "ia64" \) \) ; then Doh. Still not quite right... Clean patch below. Signed-off-by: Dustin Kirkland =3D=3D=3D modified file 'configure' --- configure 2009-06-17 11:16:33 +0000 +++ configure 2009-06-24 23:13:00 +0000 @@ -2117,13 +2117,12 @@ fi } =20 -if [ use_upstream_kvm =3D yes ]; then - # Make sure the target and host cpus are compatible if test ! \( "$target_cpu" =3D "$cpu" -o \ \( "$target_cpu" =3D "ppcemb" -a "$cpu" =3D "ppc" \) -o \ \( "$target_cpu" =3D "x86_64" -a "$cpu" =3D "i386" \) -o \ - \( "$target_cpu" =3D "i386" -a "$cpu" =3D "x86_64" \) \) ; then + \( "$target_cpu" =3D "i386" -a "$cpu" =3D "x86_64" \) -o \ + \( "$target_cpu" =3D "ia64" -a "$cpu" =3D "ia64" \) \) ; then target_kvm=3D"no" fi # Disable KVM for linux-user @@ -2131,8 +2130,6 @@ target_kvm=3D"no" fi =20 -fi - case "$target_cpu" in i386) echo "TARGET_ARCH=3Di386" >> $config_mak --=-uzi6Mf03Z+BwDsr9WjUa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkpCs1kACgkQs7pNXIOmEZRQxgCbBrs4z1FtXsFTsquBp+XXPjZP 060An2pUeWMVtWRoE139DPKiMi4h47zs =5Bfc -----END PGP SIGNATURE----- --=-uzi6Mf03Z+BwDsr9WjUa--