From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ram Pai Subject: Re: [PATCH] support colon in filenames Date: Thu, 25 Jun 2009 10:52:02 -0700 Message-ID: <1245952322.6278.77.camel@localhost> References: <1245862739.6278.7.camel@localhost> <1245866233.6278.17.camel@localhost> <4A434009.5010009@redhat.com> Reply-To: linuxram@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm-devel , Anthony Liguori , qemu-devel@nongnu.org To: Kevin Wolf Return-path: Received: from e37.co.us.ibm.com ([32.97.110.158]:40451 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752543AbZFYRwQ (ORCPT ); Thu, 25 Jun 2009 13:52:16 -0400 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e37.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5PHpa1c013987 for ; Thu, 25 Jun 2009 11:51:36 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5PHqA7N070046 for ; Thu, 25 Jun 2009 11:52:10 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5PHq78i014303 for ; Thu, 25 Jun 2009 11:52:09 -0600 In-Reply-To: <4A434009.5010009@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2009-06-25 at 11:14 +0200, Kevin Wolf wrote: > Ram Pai schrieb: > > Copying the qemu-devel mailing list too. > > > > On Wed, 2009-06-24 at 09:58 -0700, Ram Pai wrote: > >> Problem: It is impossible to feed filenames with the character colon because > >> qemu interprets such names as a protocol. For example a filename scsi:0, > >> is interpreted as a protocol by name "scsi". > >> > >> This patch allows users to espace colon characters. For example the above filename > >> can now be expressed as 'scsi\:0' > >> > >> Here are couple of examples: > >> > >> ndb:\::9999 is treated as a ndb protocol with a hostname ':' on port 9999 > >> scsi\:0\:abc is a local file scsi:0:abc > >> http\://myweb is a local file by name http://myweb > >> nbd\::localhost:2558 is a protocol by name nbd: > > Is there any use in having a host named : or protocol nbd:? I don't > think so. I do not see the utility either. However if one does find a novel use, the syntax is expressive enough. > > The other examples could be achieved much easier by assigning > the file: protocol to raw, so we would have: > file:scsi:0:abc > file:http://myweb yes. This is something if implemented; would help. But then its another mechanism for expression. It has to be a separate patch built on top of this patch, because you will still need escaping characters like space, comma, etc > > This solution wasn't accepted last time because it wouldn't solve the > problems with other characters like commas (they need to be escaped as > double comma on the command line) and that won't be solved by this patch > either. This patch does handle commas and any other character as long as it is escaped using backslashes. I just checked the man page and it says that commas in the filename can be escaped by commas :( . Ok i will add that feature to my patch and resend it. Will that be acceptable after that? Thanks, RP > > Kevin