Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

Anthony Liguori
2009-07-16T14:10:54Z

Markus Armbruster wrote:
> Anthony Liguori <aliguori@us.ibm.com> writes:
>
>
>> Blue Swirl wrote:
>>
>>> Then how about something like:
>>> -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img
>>> -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img
>>> -drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img
>>>
>>>
>> The explicit ordering part seems clunky to me. How about:
>>
>> -drive name=vda,if=virtio -drive.vda.file filename.img
>>
>> What's nice about this syntax is it generalizes well. You could have:
>>
>> -drive.vda.if virtio -drive.vda.file filename.img
>> -net nic,model=rtl8139,name=foo -net.foo.macaddr 00:11:43:55:44:22
>>
>
> Sanest proposal so far. Just put filenames in separate arguments, as
> with almost every other program.
>
> Instead of name=, let's use id= from Gerd's qdev work.
>

Works for me.

> Why "-drive.ID.NAME VALUE", "-net.ID.NAME VALUE" and so forth, i.e. one
> option per object with parameters? Assuming the ID name space is flat,
> a single option suffices. What about "-set ID.NAME=VALUE"?
>

Looks attractive on the surface. Feels really difficult to implement :-)

> Quoting is problematic. Not only because it necessarily breaks some
> filenames that used to work, also because the shell quotes, too. I
> don't enjoy counting backslashes.
>

Yup.

Regards,

Anthony Liguori