From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: [PATCH] Warn if a qcow (not qcow2) file is opened Date: Mon, 29 Jun 2009 17:04:49 +0300 Message-ID: <1246284289-25394-1-git-send-email-avi@redhat.com> Cc: kvm@vger.kernel.org To: qemu-devel@nongnu.org Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46118 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbZF2OEu (ORCPT ); Mon, 29 Jun 2009 10:04:50 -0400 Sender: kvm-owner@vger.kernel.org List-ID: The qcow block driver format is no longer maintained and likely contains serious data corruptors. Urge users to stay away for it, and advertise the new and improved replacement. Signed-off-by: Avi Kivity --- block/qcow.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 55a68a6..2aef6a6 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -101,6 +101,11 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags) return ret; if (bdrv_pread(s->hd, 0, &header, sizeof(header)) != sizeof(header)) goto fail; + + fprintf(stderr, + "WARNING: the qcow file format is no longer supported.\n" + " Please convert your images to qcow2.\n"); + be32_to_cpus(&header.magic); be32_to_cpus(&header.version); be64_to_cpus(&header.backing_file_offset); -- 1.6.0.6