From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suresh Siddha Subject: Re: [PATCH v3] enable x2APIC without interrupt remapping under KVM Date: Mon, 29 Jun 2009 07:58:39 -0700 Message-ID: <1246287519.27006.10660.camel@localhost.localdomain> References: <20090629132926.GB20289@redhat.com> Reply-To: suresh.b.siddha@intel.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "linux-kernel@vger.kernel.org" , Sheng Yang , "kvm@vger.kernel.org" , "avi@redhat.com" To: Gleb Natapov Return-path: Received: from mga14.intel.com ([143.182.124.37]:36856 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753487AbZF2PBm (ORCPT ); Mon, 29 Jun 2009 11:01:42 -0400 In-Reply-To: <20090629132926.GB20289@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2009-06-29 at 06:29 -0700, Gleb Natapov wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index d1430ef..3e5b6ea 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -260,12 +260,15 @@ config SMP > > config X86_X2APIC > bool "Support x2apic" > - depends on X86_LOCAL_APIC && X86_64 && INTR_REMAP > + depends on X86_LOCAL_APIC && X86_64 Thinking more, probably we shouldn't remove this dependency. This might encourage people (knowingly or unknowingly) to enable x2apic without interrupt-remapping. Can we remove this? KVM mode will still work even if we fail to enable interrupt-remapping. So this shouldn't be an issue, correct? Sorry I should have commented about this before. > > ioapic_entries = alloc_ioapic_entries(); > if (!ioapic_entries) { > - pr_info("Allocate ioapic_entries failed: %d\n", ret); > - goto end; > + pr_info("Allocate ioapic_entries failed\n"); > + return; We should go to ir_failed .. > } > > ret = save_IO_APIC_setup(ioapic_entries); > if (ret) { > pr_info("Saving IO-APIC state failed: %d\n", ret); > - goto end; > + free_ioapic_entries(ioapic_entries); > + return; same here. In few hours I will be on 24 hour flight. So please bear with me for delayed responses. thanks, suresh