From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: sudhir kumar <smalikphy@gmail.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org,
Alexey Eromenko <aeromenk@redhat.com>
Subject: Re: [KVM-AUTOTEST PATCH] Adding iperf test
Date: Tue, 30 Jun 2009 19:46:25 -0300 [thread overview]
Message-ID: <1246401985.9596.137.camel@freedom> (raw)
In-Reply-To: <a50cf5ab0906300152h1839f596nf6164f38e58090e@mail.gmail.com>
On Tue, 2009-06-30 at 14:22 +0530, sudhir kumar wrote:
> On Wed, Jun 17, 2009 at 2:59 AM, Lucas Meneghel Rodrigues<lmr@redhat.com> wrote:
> > Adding iperf network performance test. Basically it tests
> > networking functionality, stability and performance of guest OSes.
> > This test is cross-platform -- i.e. it works on both Linux and
> > Windows VMs.
> >
>
> I have a question here. Why are we adding iperf in a way different
> than other tests ? We have client/tests/<different_tests> directory
> for each test which contains the python modules and the test tarball.
> Then why in case of iperf we are putting it under client/tests/kvm and
> modifying kvm.py instead of putting the testsuit as part of
> autotest(run_autotest is not enough?)? Even if we do not want to touch
> the existing iperf test in autotest we can use a separate name like
> kvm_iperf. Somehow I have a feeling that there was a discussion on the
> list for keeping tests under a particular directory. But still I feel
> that should be only for tests specific to KVM and not the guest. Is
> there any disadvantage of using the current approach of executing
> these testsuits ?
Since the kvm subtests are contained under the kvm test dir, adding the
kvm_ file prefixes to the subtests is not necessary IMHO.
Using the autotest iperf test is doable for linux guests, though it
doesn't work for windows guests, that's why Alexey decided to implement
it from scratch.
Lucas
next prev parent reply other threads:[~2009-06-30 22:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 21:29 [KVM-AUTOTEST PATCH] Adding iperf test Lucas Meneghel Rodrigues
2009-06-16 21:40 ` Lucas Meneghel Rodrigues
2009-06-16 23:43 ` Lucas Meneghel Rodrigues
2009-06-25 15:54 ` [KVM-AUTOTEST PATCH] bugfix for changing kvm_log to logging Yolkfull Chow
2009-07-01 3:24 ` Lucas Meneghel Rodrigues
2009-06-30 8:52 ` [KVM-AUTOTEST PATCH] Adding iperf test sudhir kumar
2009-06-30 22:46 ` Lucas Meneghel Rodrigues [this message]
2009-07-01 11:43 ` Alexey Eremenko
2009-07-01 15:57 ` Lucas Meneghel Rodrigues
2009-07-01 16:18 ` [Autotest] " Martin Bligh
2009-07-01 17:14 ` Avi Kivity
2009-07-01 17:16 ` Martin Bligh
2009-07-01 20:29 ` Lucas Meneghel Rodrigues
2009-07-02 8:26 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246401985.9596.137.camel@freedom \
--to=lmr@redhat.com \
--cc=aeromenk@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=smalikphy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox