From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: [PATCH] KVM: Fix IA32e Windows can't boot issue Date: Wed, 1 Jul 2009 16:07:51 +0800 Message-ID: <1246435671-25485-1-git-send-email-sheng@linux.intel.com> Cc: Marcelo Tosatti , kvm@vger.kernel.org, Sheng Yang To: Avi Kivity Return-path: Received: from mga02.intel.com ([134.134.136.20]:60064 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752653AbZGAIIH (ORCPT ); Wed, 1 Jul 2009 04:08:07 -0400 Sender: kvm-owner@vger.kernel.org List-ID: One typo in commit: "KVM: convert custom marker based tracing to event traces" caused: set_cr8: #GP, reserved bits 0x7f when try to boot up IA32e Windows guest. One value has been written to R8 instead of specific register, then the value of specific register can be invalid as CR8. Guest RMW it, then got trouble. Signed-off-by: Sheng Yang --- arch/x86/kvm/vmx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 119fa47..3a75db3 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -2903,7 +2903,7 @@ static int handle_cr(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) return 1; case 8: val = kvm_get_cr8(vcpu); - kvm_register_write(vcpu, cr, val); + kvm_register_write(vcpu, reg, val); trace_kvm_cr_read(cr, val); skip_emulated_instruction(vcpu); return 1; -- 1.5.4.5