Re: [Qemu-devel] [PATCH] rev3: support colon in filenames

Jamie Lokier
2009-07-15T22:51:54Z

Anthony Liguori wrote:
> Jamie Lokier wrote:
> >Anthony Liguori wrote:
> >
> >>Jan Kiszka wrote:
> >>
> >>>We would still have to deal with the fact that so far '\' had no special
> >>>meaning on Windows - except that is was the well-known path separator.
> >>>So redefining its meaning would break a bit...
> >>>
> >>>
> >>That's the problem. You will break existing Windows users.
> >>
> >>I know this goes against the current momentum in qemu, but overloading
> >>one option with a bunch of parameters seems absolutely silly to me.
> >>
> >>IMHO, -drive file=foo.img,if=virtio,cache=off should have always been at
> >>least three parameters.
> >>
> >
> >That's fine for command lines. I don't necessarily disagree with you.
> >
> >But how do you propose to handle paths in monitor commands, when the
> >path contains a space/quote/whatever as it often does on Windows ("My
> >Documents", "Program Files")?
> >
>
> Same basic rules apply. The monitor should use shell-style quoting.

So instead of consistency, you like the idea of using different
quoting rules for the monitor than for command line arguments?

-- Jamie