public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Yolkfull Chow <yzhou@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Fri, 03 Jul 2009 02:03:51 -0300	[thread overview]
Message-ID: <1246597431.3378.11.camel@localhost.localdomain> (raw)
In-Reply-To: <1246580603.6508.25.camel@localhost.localdomain>

On Thu, 2009-07-02 at 21:23 -0300, Lucas Meneghel Rodrigues wrote:
> Ok, I've been trough the test and took a look at the testsuite itself.
> Both look good. The testsuite requires a very current qemu-img package,
> due to the use of qemu-io (F11 for instance doesn't ship it). So if you
> want to try this make sure you use a current version of the kvm
> utilities.

It just occurred to me some suggestions based on my last comment:
 * Make sure we have the qemu, qemu-img and the qemu-io ELF files
available to execute the test suite, and if we doesn't, raise a
error.TestError() exception.
 * Make it possible to specify an alternate prefix to look for those
ELFs, and make sure the test suite can find them (ie, appending the path
to os.environ['PATH']).

Yolkfull, please take a look at implementing those suggestions.

Thanks again for your work!

Lucas


  parent reply	other threads:[~2009-07-03  5:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1246505385-8398-1-git-send-email-yzhou@redhat.com>
2009-07-02  3:49 ` [Autotest] [PATCH] Add a client-side test qemu_iotests Martin Bligh
2009-07-02  4:26   ` Yolkfull Chow
     [not found]     ` <4A518680.2050706@redhat.com>
     [not found]       ` <4A5188DA.30303@redhat.com>
2009-07-06  7:21         ` Lucas Meneghel Rodrigues
     [not found] ` <a50cf5ab0907012124k6bbef79dkfad02ddb0e09948e@mail.gmail.com>
2009-07-02  4:46   ` Yolkfull Chow
2009-07-02 12:26     ` Lucas Meneghel Rodrigues
     [not found]     ` <4A4C414E.6000806@redhat.com>
2009-07-03  0:23       ` Lucas Meneghel Rodrigues
2009-07-03  2:01         ` Yolkfull Chow
2009-07-03  5:03         ` Lucas Meneghel Rodrigues [this message]
2009-07-03  5:11           ` Yolkfull Chow
2009-07-03  9:18           ` Yolkfull Chow
2009-07-03 12:37             ` Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246597431.3378.11.camel@localhost.localdomain \
    --to=lmr@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=yzhou@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox