From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests Date: Fri, 03 Jul 2009 02:03:51 -0300 Message-ID: <1246597431.3378.11.camel@localhost.localdomain> References: <1246505385-8398-1-git-send-email-yzhou@redhat.com> <4A4C3BB5.8040003@redhat.com> <4A4C414E.6000806@redhat.com> <1246580603.6508.25.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Yolkfull Chow Return-path: Received: from mx2.redhat.com ([66.187.237.31]:52336 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbZGCFD4 (ORCPT ); Fri, 3 Jul 2009 01:03:56 -0400 In-Reply-To: <1246580603.6508.25.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2009-07-02 at 21:23 -0300, Lucas Meneghel Rodrigues wrote: > Ok, I've been trough the test and took a look at the testsuite itself. > Both look good. The testsuite requires a very current qemu-img package, > due to the use of qemu-io (F11 for instance doesn't ship it). So if you > want to try this make sure you use a current version of the kvm > utilities. It just occurred to me some suggestions based on my last comment: * Make sure we have the qemu, qemu-img and the qemu-io ELF files available to execute the test suite, and if we doesn't, raise a error.TestError() exception. * Make it possible to specify an alternate prefix to look for those ELFs, and make sure the test suite can find them (ie, appending the path to os.environ['PATH']). Yolkfull, please take a look at implementing those suggestions. Thanks again for your work! Lucas