From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Yolkfull Chow <yzhou@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org,
Martin Bligh <mbligh@google.com>
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Mon, 06 Jul 2009 04:21:48 -0300 [thread overview]
Message-ID: <1246864908.2865.62.camel@localhost.localdomain> (raw)
In-Reply-To: <4A5188DA.30303@redhat.com>
On Mon, 2009-07-06 at 13:17 +0800, Yolkfull Chow wrote:
> Hi Lucas, since the qemu_iotests test suite itself has checked qemu,
> qemu-img and qemu-io ELF files before running, I would skip the
> duplicated step.
Fair enough. Making the check on the autotest module would make things
more apparent to the user (we would throw a TestFailure with the
reason), but I see your point.
> I added 'qemu_path' option for users to specify their alternative PATH
> containing these ELF files.
>
> > + if qemu_path:
> > + os.environ['PATH'] += ":" + qemu_path
> > +
Good.
Martin, any comments? The test module and the qemu-iotests suite are
looking good, can we commit it?
Lucas
next prev parent reply other threads:[~2009-07-06 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1246505385-8398-1-git-send-email-yzhou@redhat.com>
2009-07-02 3:49 ` [Autotest] [PATCH] Add a client-side test qemu_iotests Martin Bligh
2009-07-02 4:26 ` Yolkfull Chow
[not found] ` <4A518680.2050706@redhat.com>
[not found] ` <4A5188DA.30303@redhat.com>
2009-07-06 7:21 ` Lucas Meneghel Rodrigues [this message]
[not found] ` <a50cf5ab0907012124k6bbef79dkfad02ddb0e09948e@mail.gmail.com>
2009-07-02 4:46 ` Yolkfull Chow
2009-07-02 12:26 ` Lucas Meneghel Rodrigues
[not found] ` <4A4C414E.6000806@redhat.com>
2009-07-03 0:23 ` Lucas Meneghel Rodrigues
2009-07-03 2:01 ` Yolkfull Chow
2009-07-03 5:03 ` Lucas Meneghel Rodrigues
2009-07-03 5:11 ` Yolkfull Chow
2009-07-03 9:18 ` Yolkfull Chow
2009-07-03 12:37 ` Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246864908.2865.62.camel@localhost.localdomain \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mbligh@google.com \
--cc=yzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox