From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Mon, 06 Jul 2009 04:21:48 -0300
Message-ID: <1246864908.2865.62.camel@localhost.localdomain>
References: <1246505385-8398-1-git-send-email-yzhou@redhat.com>
	 <33307c790907012049u18b118b6rd482a70001cb8424@mail.gmail.com>
	 <4A4C3700.3070608@redhat.com> <4A518680.2050706@redhat.com>
	 <4A5188DA.30303@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: autotest@test.kernel.org, kvm@vger.kernel.org,
	Martin Bligh <mbligh@google.com>
To: Yolkfull Chow <yzhou@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:47331 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754059AbZGFHVv (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 Jul 2009 03:21:51 -0400
In-Reply-To: <4A5188DA.30303@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 2009-07-06 at 13:17 +0800, Yolkfull Chow wrote:

> Hi Lucas, since the qemu_iotests test suite itself has checked qemu,
> qemu-img and qemu-io ELF files before running, I would skip the
> duplicated step.

Fair enough. Making the check on the autotest module would make things
more apparent to the user (we would throw a TestFailure with the
reason), but I see your point.

> I added 'qemu_path' option for users to specify their alternative PATH
> containing these ELF files. 
> 
> > +        if qemu_path: 
> > +            os.environ['PATH'] += ":" + qemu_path 
> > + 

Good.

Martin, any comments? The test module and the qemu-iotests suite are
looking good, can we commit it?

Lucas