From: Gleb Natapov <gleb@redhat.com>
To: kvm@vger.kernel.org
Cc: avi@redhat.com, mtosatti@redhat.com
Subject: [PATCH 3/5] Move irq notifiers lists to its own locking.
Date: Mon, 13 Jul 2009 12:12:33 +0300 [thread overview]
Message-ID: <1247476355-27284-4-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1247476355-27284-1-git-send-email-gleb@redhat.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
include/linux/kvm_host.h | 1 +
virt/kvm/irq_comm.c | 16 ++++++++--------
virt/kvm/kvm_main.c | 1 +
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 3f2a4fc..12f4ee2 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -165,6 +165,7 @@ struct kvm {
spinlock_t irq_routing_lock;
struct hlist_head mask_notifier_list;
struct hlist_head irq_ack_notifier_list;
+ spinlock_t irq_notifier_list_lock;
#endif
#ifdef KVM_ARCH_WANT_MMU_NOTIFIER
diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c
index 3dbba41..59c1cde 100644
--- a/virt/kvm/irq_comm.c
+++ b/virt/kvm/irq_comm.c
@@ -191,17 +191,17 @@ void kvm_notify_acked_irq(struct kvm *kvm, unsigned irqchip, unsigned pin)
void kvm_register_irq_ack_notifier(struct kvm *kvm,
struct kvm_irq_ack_notifier *kian)
{
- mutex_lock(&kvm->irq_lock);
+ spin_lock(&kvm->irq_notifier_list_lock);
hlist_add_head_rcu(&kian->link, &kvm->irq_ack_notifier_list);
- mutex_unlock(&kvm->irq_lock);
+ spin_unlock(&kvm->irq_notifier_list_lock);
}
void kvm_unregister_irq_ack_notifier(struct kvm *kvm,
struct kvm_irq_ack_notifier *kian)
{
- mutex_lock(&kvm->irq_lock);
+ spin_lock(&kvm->irq_notifier_list_lock);
hlist_del_init_rcu(&kian->link);
- mutex_unlock(&kvm->irq_lock);
+ spin_unlock(&kvm->irq_notifier_list_lock);
synchronize_rcu();
}
@@ -247,18 +247,18 @@ void kvm_free_irq_source_id(struct kvm *kvm, int irq_source_id)
void kvm_register_irq_mask_notifier(struct kvm *kvm, int irq,
struct kvm_irq_mask_notifier *kimn)
{
- mutex_lock(&kvm->irq_lock);
+ spin_lock(&kvm->irq_notifier_list_lock);
kimn->irq = irq;
hlist_add_head_rcu(&kimn->link, &kvm->mask_notifier_list);
- mutex_unlock(&kvm->irq_lock);
+ spin_unlock(&kvm->irq_notifier_list_lock);
}
void kvm_unregister_irq_mask_notifier(struct kvm *kvm, int irq,
struct kvm_irq_mask_notifier *kimn)
{
- mutex_lock(&kvm->irq_lock);
+ spin_lock(&kvm->irq_notifier_list_lock);
hlist_del_rcu(&kimn->link);
- mutex_unlock(&kvm->irq_lock);
+ spin_unlock(&kvm->irq_notifier_list_lock);
synchronize_rcu();
}
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 4e31634..018bde8 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -948,6 +948,7 @@ static struct kvm *kvm_create_vm(void)
spin_lock_init(&kvm->irq_routing_lock);
INIT_HLIST_HEAD(&kvm->mask_notifier_list);
INIT_HLIST_HEAD(&kvm->irq_ack_notifier_list);
+ spin_lock_init(&kvm->irq_notifier_list_lock);
#endif
#ifdef KVM_COALESCED_MMIO_PAGE_OFFSET
--
1.6.2.1
next prev parent reply other threads:[~2009-07-13 9:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 9:12 [PATCH 0/5][RFC] more fine grained locking for IRQ injection Gleb Natapov
2009-07-13 9:12 ` [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock Gleb Natapov
2009-07-13 14:29 ` Gregory Haskins
2009-07-13 14:39 ` Gleb Natapov
2009-07-13 14:55 ` Michael S. Tsirkin
2009-07-13 15:01 ` Gleb Natapov
2009-07-13 15:03 ` Gregory Haskins
2009-07-13 15:11 ` Gregory Haskins
2009-07-13 15:19 ` Gleb Natapov
2009-07-13 9:12 ` [PATCH 2/5] Move irq routing to its own locking Gleb Natapov
2009-07-13 9:12 ` Gleb Natapov [this message]
2009-07-13 11:45 ` [PATCH 3/5] Move irq notifiers lists " Michael S. Tsirkin
2009-07-13 11:48 ` Gleb Natapov
2009-07-13 14:23 ` Michael S. Tsirkin
2009-07-13 14:37 ` Gleb Natapov
2009-07-13 14:49 ` Michael S. Tsirkin
2009-07-13 15:23 ` Gleb Natapov
2009-07-13 15:32 ` Gregory Haskins
2009-07-13 15:40 ` Michael S. Tsirkin
2009-07-13 16:28 ` Gleb Natapov
2009-07-13 16:23 ` Marcelo Tosatti
2009-07-13 16:31 ` Marcelo Tosatti
2009-07-13 16:35 ` Gleb Natapov
2009-07-13 16:43 ` Marcelo Tosatti
2009-07-13 9:12 ` [PATCH 4/5] Move IO APIC to its own lock Gleb Natapov
2009-07-13 9:12 ` [PATCH 5/5] Drop kvm->irq_lock lock Gleb Natapov
2009-07-13 13:23 ` [PATCH 0/5][RFC] more fine grained locking for IRQ injection Michael S. Tsirkin
2009-07-13 13:28 ` Gleb Natapov
2009-07-13 13:53 ` Michael S. Tsirkin
2009-07-13 13:58 ` Gleb Natapov
2009-07-13 14:21 ` Michael S. Tsirkin
2009-07-13 14:33 ` Gleb Natapov
2009-07-13 14:43 ` Michael S. Tsirkin
2009-07-13 15:21 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247476355-27284-4-git-send-email-gleb@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox