From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH 1/2] KVM test: Do a better job at handling kvm module failures Date: Tue, 14 Jul 2009 10:34:55 -0300 Message-ID: <1247578495.3093.2.camel@localhost.localdomain> References: <1247513217-21075-1-git-send-email-lmr@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: autotest@test.kernel.org Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35173 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753501AbZGNNe7 (ORCPT ); Tue, 14 Jul 2009 09:34:59 -0400 In-Reply-To: <1247513217-21075-1-git-send-email-lmr@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2009-07-13 at 16:26 -0300, Lucas Meneghel Rodrigues wrote: > Developers might want to use the KVM test to verify changes > only on their own local qemu source directory and will use the > 'localsrc' install mode on the KVM test control file, and > provide 'load_modules': 'no' option on the params dict inside > the kvm control file. However, that option is not documented and > defaults to 'yes', and when the code to load kvm modules can't > find a built kvm.ko module inside the source dir, an unhandled > error exception (totally unhelpful) will be thrown. > > This patch makes the test throw a much more helpful error message, > helping the developer to figure out what is wrong and fix the > problem. Applied.