From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ram Pai <linuxram@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames
Date: Thu, 16 Jul 2009 00:39:27 -0700
Message-ID: <1247729967.14246.139.camel@localhost>
References: <1245862739.6278.7.camel@localhost>
	 <1245998284.6278.99.camel@localhost> <4A447C8D.5000104@kevin-wolf.de>
	 <1246063310.6278.115.camel@localhost>	 <1246511321.6429.31.camel@localhost>
	 <4A4C754D.10109@redhat.com>	 <4A4CAD86.9020607@us.ibm.com>
	 <4A4CB39F.5070506@redhat.com>	 <1247041831.6297.12.camel@localhost>
	 <1247644283.14246.3.camel@localhost>
	 <f43fc5580907150804l2d7efcb5k39f11dfa2f209f20@mail.gmail.com>
Reply-To: linuxram@us.ibm.com
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Jan Kiszka <jan.kiszka@web.de>, kvm-devel <kvm@vger.kernel.org>
To: Blue Swirl <blauwirbel@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e35.co.us.ibm.com ([32.97.110.153]:35303 "EHLO
	e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752138AbZGPHja (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 16 Jul 2009 03:39:30 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227])
	by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6G7VS2r020104
	for <kvm@vger.kernel.org>; Thu, 16 Jul 2009 01:31:28 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6G7dTjR202878
	for <kvm@vger.kernel.org>; Thu, 16 Jul 2009 01:39:29 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6G7dTNq030249
	for <kvm@vger.kernel.org>; Thu, 16 Jul 2009 01:39:29 -0600
In-Reply-To: <f43fc5580907150804l2d7efcb5k39f11dfa2f209f20@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 2009-07-15 at 18:04 +0300, Blue Swirl wrote:
> On 7/15/09, Ram Pai <linuxram@us.ibm.com> wrote:
> > Problem: It is impossible to feed filenames with the character colon because
> >  qemu interprets such names as a protocol. For example filename scsi:0, is
> >  interpreted as a protocol by name "scsi".
> 
> >  --- a/block/raw-posix.c
> >  +++ b/block/raw-posix.c
> >  +static int qemu_open(const char *filename, int flags, ...)
> 
> >  --- a/block/raw-win32.c
> >  +++ b/block/raw-win32.c
> >  +    fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
> 
> I bet this won't compile on win32.

yes. good catch. fix is in the next revision(rev 6). However I do not
have a setup to compile and test changes in win32-raw.c . I will have to
rely on somebody to do the testing. 

RP