From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [KVM_AUTOTEST] add kvm hugepage variant
Date: Mon, 20 Jul 2009 09:58:48 -0300
Message-ID: <1248094728.5318.18.camel@localhost.localdomain>
References: <4A55B759.5080302@redhat.com>  <4A57118F.3030907@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: KVM list <kvm@vger.kernel.org>, Jason Wang <jasowang@redhat.com>,
	Michael Goldish <mgoldish@redhat.com>,
	Autotest mailing list <autotest@test.kernel.org>
To: =?UTF-8?Q?Luk=C3=A1=C5=A1?= Doktor <ldoktor@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:37017 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752050AbZGTM6y (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 20 Jul 2009 08:58:54 -0400
In-Reply-To: <4A57118F.3030907@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 2009-07-10 at 12:01 +0200, Luk=C3=A1=C5=A1 Doktor wrote:
> After discussion I split the patches.

Hi Luk=C3=A1=C5=A1, sorry for the delay answering your patch. Looks goo=
d to me in
general, I have some remarks to make:

1) When posting patches to the autotest kvm tests, please cross post th=
e
autotest mailing list (autotest@test.kernel.org) and the KVM list.

2) About scripts to prepare the environment to perform tests - we've ha=
d
some discussion about including shell scripts on autotest. Bottom line,
autotest has a policy of not including non python code when possible
[1]. So, would you mind re-creating your hugepage setup code in python
and re-sending it?

Thanks for your contribution, looking forward getting it integrated to
our tests.

[1] Unless when it is not practical for testing purposes - writing test=
s
in C is just fine, for example.

> This patch adds kvm_hugepage variant. It prepares the host system and
> start vm with -mem-path option. It does not clean after itself, becau=
se=20
>   it's impossible to unmount and free hugepages before all guests are=
=20
> destroyed.
>=20
> I need to ask you what to do with change of qemu parameter. Newest=20
> versions are using -mempath insted of -mem-path. This is impossible t=
o=20
> fix using current config file. I can see 2 solutions:
> 1) direct change in kvm_vm.py (parse output and try another param)
> 2) detect qemu capabilities outside and create additional layer (bett=
er=20
> for future occurrence)
>=20
> Dne 9.7.2009 11:24, Luk=C3=A1=C5=A1 Doktor napsal(a):
> > This patch adds kvm_hugepage variant. It prepares the host system a=
nd
> > start vm with -mem-path option. It does not clean after itself, bec=
ause
> > it's impossible to unmount and free hugepages before all guests are
> > destroyed.
> >
> > There is also added autotest.libhugetlbfs test.
> >
> > I need to ask you what to do with change of qemu parameter. Newest
> > versions are using -mempath insted of -mem-path. This is impossible=
 to
> > fix using current config file. I can see 2 solutions:
> > 1) direct change in kvm_vm.py (parse output and try another param)
> > 2) detect qemu capabilities outside and create additional layer (be=
tter
> > for future occurrence)
> >
> > Tested by:ldoktor@redhat.com on RHEL5.4 with kvm-83-72.el5
>=20