public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: kvm@vger.kernel.org
Cc: avi@redhat.com, Alexander Graf <agraf@suse.de>
Subject: [PATCH] unbreak booting with virtio
Date: Fri, 31 Jul 2009 14:19:09 -0400	[thread overview]
Message-ID: <1249064349-799-1-git-send-email-glommer@redhat.com> (raw)

Since commit 89e671e3, extboot is broken due to wrong checksum

The problem is that printf "\\$sum" syntax will require an octal
representation, so the fix I'm proposing is to convert it first.

Signed-off-by: Glauber Costa <glommer@redhat.com>
CC: Alexander Graf <agraf@suse.de>
---
 pc-bios/optionrom/signrom.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/pc-bios/optionrom/signrom.sh b/pc-bios/optionrom/signrom.sh
index 4322811..3512cc4 100755
--- a/pc-bios/optionrom/signrom.sh
+++ b/pc-bios/optionrom/signrom.sh
@@ -42,4 +42,5 @@ sum=$(( 256 - $sum ))
 
 # and write the output file
 cp "$1" "$2"
+sum=$(echo "obase=8; $sum" | bc)
 printf "\\$sum" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc 2>/dev/null
-- 
1.6.2.2


             reply	other threads:[~2009-07-31 18:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 18:19 Glauber Costa [this message]
2009-07-31 19:55 ` [PATCH] unbreak booting with virtio Alexander Graf
2009-07-31 23:39   ` Glauber Costa
2009-08-01  8:23     ` Alexander Graf
2009-08-01  7:04   ` Ján ONDREJ (SAL)
2009-08-01  8:01     ` Ján ONDREJ (SAL)
2009-08-01  8:19       ` Alexander Graf
2009-08-01  8:47         ` Ján ONDREJ (SAL)
2009-08-01  8:20   ` Paolo Bonzini
2009-08-03 12:37 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249064349-799-1-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=agraf@suse.de \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox