From: Gleb Natapov <gleb@redhat.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH 1/3] Call kvm_vcpu_kick() inside pic spinlock
Date: Tue, 4 Aug 2009 15:30:27 +0300 [thread overview]
Message-ID: <1249389029-12801-2-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1249389029-12801-1-git-send-email-gleb@redhat.com>
d5ecfdd25 moved it out because back than it was impossible to
call it inside spinlock. This restriction no longer exists.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
arch/x86/kvm/i8259.c | 10 +---------
arch/x86/kvm/irq.h | 1 -
2 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
index daf4606..d27320c 100644
--- a/arch/x86/kvm/i8259.c
+++ b/arch/x86/kvm/i8259.c
@@ -43,11 +43,9 @@ static void pic_unlock(struct kvm_pic *s)
{
struct kvm *kvm = s->kvm;
unsigned acks = s->pending_acks;
- bool wakeup = s->wakeup_needed;
struct kvm_vcpu *vcpu;
s->pending_acks = 0;
- s->wakeup_needed = false;
spin_unlock(&s->lock);
@@ -56,12 +54,6 @@ static void pic_unlock(struct kvm_pic *s)
__ffs(acks));
acks &= acks - 1;
}
-
- if (wakeup) {
- vcpu = s->kvm->bsp_vcpu;
- if (vcpu)
- kvm_vcpu_kick(vcpu);
- }
}
static void pic_clear_isr(struct kvm_kpic_state *s, int irq)
@@ -527,7 +519,7 @@ static void pic_irq_request(void *opaque, int level)
s->output = level;
if (vcpu && level && (s->pics[0].isr_ack & (1 << irq))) {
s->pics[0].isr_ack &= ~(1 << irq);
- s->wakeup_needed = true;
+ kvm_vcpu_kick(vcpu);
}
}
diff --git a/arch/x86/kvm/irq.h b/arch/x86/kvm/irq.h
index 9f59318..7d6058a 100644
--- a/arch/x86/kvm/irq.h
+++ b/arch/x86/kvm/irq.h
@@ -63,7 +63,6 @@ struct kvm_kpic_state {
struct kvm_pic {
spinlock_t lock;
- bool wakeup_needed;
unsigned pending_acks;
struct kvm *kvm;
struct kvm_kpic_state pics[2]; /* 0 is master pic, 1 is slave pic */
--
1.6.3.3
next prev parent reply other threads:[~2009-08-04 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 12:30 [PATCH 0/3] PIC fixes Gleb Natapov
2009-08-04 12:30 ` Gleb Natapov [this message]
2009-08-04 12:30 ` [PATCH 2/3] Call ack notifiers from PIC when guest OS acks an IRQ Gleb Natapov
2009-08-04 12:30 ` [PATCH 3/3] Replace pic_lock()/pic_unlock() with direct call to spinlock functions Gleb Natapov
2009-08-05 19:05 ` [PATCH 0/3] PIC fixes Marcelo Tosatti
2009-08-09 9:09 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249389029-12801-2-git-send-email-gleb@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox