From: David Woodhouse <dwmw2@infradead.org>
To: Yu Zhao <yu.zhao@intel.com>
Cc: linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
kvm@vger.kernel.org, jbarnes@virtuousgeek.org
Subject: Re: [PATCH v5 6/6] VT-d: support the device IOTLB
Date: Sun, 09 Aug 2009 10:33:54 +0100 [thread overview]
Message-ID: <1249810434.4919.57.camel@macbook.infradead.org> (raw)
In-Reply-To: <1242625897-1678-7-git-send-email-yu.zhao@intel.com>
On Mon, 2009-05-18 at 13:51 +0800, Yu Zhao wrote:
> Enable the device IOTLB (i.e. ATS) for both the bare metal and KVM
> environments.
Hmmm. Your iommu_flush_dev_iotlb() function takes the _global_ spinlock
'device_domain_lock'. And you do this unconditionally -- you aren't even
calling it only for domains which have ATS-capable devices attached.
How about using a flag similar to iommu_snooping, which is recalculated
only when you add or remove a device? And only calling
iommu_flush_dev_iotlb() if that's set?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-08-09 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 5:51 [PATCH v5 0/6] ATS capability support for Intel IOMMU Yu Zhao
2009-05-18 5:51 ` [PATCH v5 1/6] PCI: support the ATS capability Yu Zhao
2009-05-18 5:51 ` [PATCH v5 2/6] PCI: handle Virtual Function ATS enabling Yu Zhao
2009-05-18 5:51 ` [PATCH v5 3/6] VT-d: parse ATSR in DMA Remapping Reporting Structure Yu Zhao
2009-05-18 5:51 ` [PATCH v5 4/6] VT-d: add device IOTLB invalidation support Yu Zhao
2009-05-18 5:51 ` [PATCH v5 5/6] VT-d: cleanup iommu_flush_iotlb_psi and flush_unmaps Yu Zhao
2009-05-18 5:51 ` [PATCH v5 6/6] VT-d: support the device IOTLB Yu Zhao
2009-06-28 14:28 ` David Woodhouse
2009-06-29 3:07 ` Yu Zhao
2009-08-09 9:33 ` David Woodhouse [this message]
2009-08-09 10:28 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249810434.4919.57.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yu.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox