From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [PATCH]: Always use KVM_VERSION to build version number Date: Mon, 10 Aug 2009 10:52:12 +0100 Message-ID: <1249897932.8784.71.camel@blaa> References: <4A7C1E96.3060200@redhat.com> <4A7E9DA9.3060204@redhat.com> <1249895994.8784.47.camel@blaa> <4A7FEC7F.9070304@redhat.com> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Chris Lalancette , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59343 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753316AbZHJJw5 (ORCPT ); Mon, 10 Aug 2009 05:52:57 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7A9qwh4009366 for ; Mon, 10 Aug 2009 05:52:58 -0400 In-Reply-To: <4A7FEC7F.9070304@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2009-08-10 at 12:46 +0300, Avi Kivity wrote: > On 08/10/2009 12:19 PM, Mark McLoughlin wrote: > > > > Or we could drop this kvm snapshot numbering system and just use qemu > > VERSION numbering - i.e. qemu-kvm-devel-88 could have been published as > > qemu-kvm-0.10.50 > > > > Yeah. You still couldn't distinguish among different snapshots. 0.10.51, 0.10.52 etc. > >> How about adding 'qemu -describe-features' which will output, one line > >> per feature, what's supported (and limits where applicable)? I > >> understand libvirt already does this for some features using -help; this > >> is simply a formalization of that hack. > >> > > > > Yes, libvirt would much rather not parse -help or use version numbers to > > detect whether features are available. > > > > We should revisit the "info capabilities" thing again: > > > > http://lists.gnu.org/archive/html/qemu-devel/2008-11/msg00767.html > > > > Logically it needs to work before starting a VM, so a command line > option is more appropriate. http://lists.gnu.org/archive/html/qemu-devel/2008-11/msg00899.html Cheers, Mark.