kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ram Pai <linuxram@us.ibm.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>,
	"Yang, Sheng" <sheng.yang@intel.com>
Subject: Re: KVM: VMX: flush TLB with INVEPT on cpu migration
Date: Fri, 02 Oct 2009 13:56:45 -0700	[thread overview]
Message-ID: <1254517005.22711.19.camel@localhost> (raw)
In-Reply-To: <20091001221658.GA22916@amt.cnet>


On Thu, 2009-10-01 at 19:16 -0300, Marcelo Tosatti wrote:
> It is possible that stale EPTP-tagged mappings are used, if a 
> vcpu migrates to a different pcpu.
> 
> Set KVM_REQ_TLB_FLUSH in vmx_vcpu_load, when switching pcpus, which
> will invalidate both VPID and EPT mappings on the next vm-entry.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index e86f1a6..97f4265 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -708,7 +708,7 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
>  	if (vcpu->cpu != cpu) {
>  		vcpu_clear(vmx);
>  		kvm_migrate_timers(vcpu);
> -		vpid_sync_vcpu_all(vmx);
> +		set_bit(KVM_REQ_TLB_FLUSH, &vcpu->requests);
>  		local_irq_disable();
>  		list_add(&vmx->local_vcpus_link,
>  			 &per_cpu(vcpus_on_cpu, cpu));
> --

This patch fixes my ept misconfig problem seen very so often while
installing sles11 guest.

thanks,
RP

 


  reply	other threads:[~2009-10-02 20:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 22:16 KVM: VMX: flush TLB with INVEPT on cpu migration Marcelo Tosatti
2009-10-02 20:56 ` Ram Pai [this message]
2009-10-21  1:18 ` Max Laier
2009-10-22 15:10   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254517005.22711.19.camel@localhost \
    --to=linuxram@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=sheng.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).