kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: Tom Lendacky <tahm@linux.vnet.ibm.com>
Cc: kvm@vger.kernel.org
Subject: Re: QemuOpts changes breaks multiple nic options
Date: Tue, 13 Oct 2009 09:58:28 +0100	[thread overview]
Message-ID: <1255424308.3136.13.camel@blaa> (raw)
In-Reply-To: <200910121705.03870.tahm@linux.vnet.ibm.com>

Hi Tom,

On Mon, 2009-10-12 at 17:05 -0500, Tom Lendacky wrote:
> The recent change to QemuOpts for the -net nic option breaks specifying -net 
> nic,... more than once.  The net_init_nic function's return value in net.c is 
> a table index, which is non-zero after the first time it is called.  The 
> qemu_opts_foreach function in qemu-option.c receives the non-zero return value 
> and stops processing further -net options (like associated -net tap options).  
> It looks like the usb net function makes use of the index value, so the fix 
> might best be to have qemu_opts_foreach check for a return code < 0 as being 
> an error?

Thanks for the report; I sent a patch to qemu-devel yesterday:

  http://lists.gnu.org/archive/html/qemu-devel/2009-10/msg01070.html

Cheers,
Mark.


      reply	other threads:[~2009-10-13  9:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 22:05 QemuOpts changes breaks multiple nic options Tom Lendacky
2009-10-13  8:58 ` Mark McLoughlin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255424308.3136.13.camel@blaa \
    --to=markmc@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=tahm@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).