From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: autotest@test.kernel.org
Cc: kvm@vger.kernel.org, mgoldish@redhat.com, jburke@redhat.com,
Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: [PATCH 3/3] KVM test: Extend VM.create() method to support SHA1 check
Date: Wed, 21 Oct 2009 19:31:47 -0200 [thread overview]
Message-ID: <1256160707-4333-3-git-send-email-lmr@redhat.com> (raw)
In-Reply-To: <1256160707-4333-2-git-send-email-lmr@redhat.com>
Also, change variable names and messages to be more
generic.
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
client/tests/kvm/kvm_vm.py | 21 ++++++++++++++-------
1 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
index a8d96ca..3d604c4 100755
--- a/client/tests/kvm/kvm_vm.py
+++ b/client/tests/kvm/kvm_vm.py
@@ -339,20 +339,27 @@ class VM:
if params.get("md5sum_1m"):
logging.debug("Comparing expected MD5 sum with MD5 sum of "
"first MB of ISO file...")
- actual_md5sum = kvm_utils.md5sum_file(iso, 1048576)
- expected_md5sum = params.get("md5sum_1m")
+ actual_hash = kvm_utils.md5sum_file(iso, 1048576)
+ expected_hash = params.get("md5sum_1m")
compare = True
elif params.get("md5sum"):
logging.debug("Comparing expected MD5 sum with MD5 sum of ISO "
"file...")
- actual_md5sum = kvm_utils.md5sum_file(iso)
- expected_md5sum = params.get("md5sum")
+ actual_hash = kvm_utils.md5sum_file(iso)
+ expected_hash = params.get("md5sum")
+ compare = True
+ elif params.get("sha1sum"):
+ logging.debug("Comparing expected SHA1 sum with SHA1 sum of "
+ "ISO file...")
+ actual_hash = kvm_utils.md5sum_file(iso)
+ expected_hash = params.get("md5sum")
compare = True
if compare:
- if actual_md5sum == expected_md5sum:
- logging.debug("MD5 sums match")
+ if actual_hash == expected_hash:
+ logging.debug("Hashes match")
else:
- logging.error("Actual MD5 sum differs from expected one")
+ logging.error("Actual hash %s differs from expected "
+ "one %s", actual_hash, expected_hash)
return False
# Make sure the following code is not executed by more than one thread
--
1.6.2.5
next prev parent reply other threads:[~2009-10-21 21:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 21:31 [PATCH 1/3] KVM test: Add new utility functions to kvm_utils Lucas Meneghel Rodrigues
2009-10-21 21:31 ` [PATCH 2/3] KVM test: Daily DVD test control file Lucas Meneghel Rodrigues
2009-10-21 21:31 ` Lucas Meneghel Rodrigues [this message]
2009-10-22 10:58 ` [Autotest] [PATCH 3/3] KVM test: Extend VM.create() method to support SHA1 check Uri Lublin
2009-10-22 10:56 ` [Autotest] [PATCH 1/3] KVM test: Add new utility functions to kvm_utils Uri Lublin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256160707-4333-3-git-send-email-lmr@redhat.com \
--to=lmr@redhat.com \
--cc=autotest@test.kernel.org \
--cc=jburke@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox